Addresses #4615, wrap OutputControl:Table:Style and Output:SQLite

[joseph-robertson]

Pull request overview

• Fixes Wrap OutputControl:Table:Style and Output:SQLite #4615
• Also adds FT tests (missing?) and RT support for OutputControlReportingTolerances

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Addresses #4615, wrap OutputControl:Table:Style and Output:SQLite OpenStudio-resources#171
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

This is looking really good. I added a couple of minor suggestions.

[jmarrec]

(No changes needed, but FYI if we end up making our IDD (or Ctor) use the same defaults as the FT, you could just call model.getUniqueModelObject() to instantiate the object as we operate on a copy of our model to begin with. This is maybe clearer this way though.)

[jmarrec]

(could use the same ft and model).

[ci-commercialbuildings]

CI Results for 979cc26:

• Ubuntu 18.04:

  • OpenStudio-3.4.1-alpha+979cc268b6-Ubuntu-18.04.deb
  • OpenStudio-3.4.1-alpha+979cc268b6-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.4.1-alpha+f25e7b235a-Ubuntu-20.04.deb
  • OpenStudio-3.4.1-alpha+f25e7b235a-Ubuntu-20.04.tar.gz
  • perf_all.csv
  • perf_comparison.png
  • perf_means.csv

• Darwin:

• Windows:

• Code Coverage: