Conversation
Collaborator
dguittet
commented
Jul 31, 2024
dguittet
commented
- Want to match up the SSC branch of the same name, if that exists
- for Push, there's no destination branch, so the default branch needs to be stated explicitly in ci.yml
- for PR, there's a destination branch, so use that as the default branch
brtietz
reviewed
Aug 1, 2024
|
|
||
| - name: Get branch name for push | ||
| if: ${{ github.event_name == 'push' }} | ||
| echo "GIT_BRANCH=${{ github.ref_name }}" >> $GITHUB_ENV |
Collaborator
There was a problem hiding this comment.
This did not have the intended effect.
SSC won't have an 1827/merge ref, so this will always default to patch. I think this does return the correct value for a push, but not a pull_request.
Is the right move to override with github.head_ref in the if block below?
brtietz
reviewed
Aug 13, 2024
brtietz
approved these changes
Aug 15, 2024
Collaborator
brtietz
left a comment
brtietz
left a comment
There was a problem hiding this comment.
Latest version looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.