Merged
Conversation
Collaborator
Author
|
@brtietz This one incorporates changes from #1827 but with a lot of the CI improvements that have already been added for lk, wex and ssc. There's a bunch of commented out code that gets us half-way to running SAM GUI tests on Windows. I have it there atm in case in the near future we want to work on enabling those tests. But, I could store that code somewhere else that isn't bogging down the ci.yml |
brtietz
approved these changes
Aug 15, 2024
Collaborator
brtietz
left a comment
There was a problem hiding this comment.
This all looks like a great improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #1769 but without running the Windows SAM UI tests
Type of change