Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long lists not scrollable all way through #1108

Closed
YSO-kokous opened this issue Dec 15, 2020 · 3 comments · Fixed by #1134
Closed

Long lists not scrollable all way through #1108

YSO-kokous opened this issue Dec 15, 2020 · 3 comments · Fixed by #1134
Assignees
Labels
Milestone

Comments

@YSO-kokous
Copy link

YSO-kokous commented Dec 15, 2020

For example, when scrolling down YSO alphabetical tab with no letter selected, scroll starts from A and only reaches down to less than midpoint of the list. See attached image: could only scroll down to YSO's agentiivisuus (kielitiede) and not further. I was using Mozilla Firefox. When a letter is clicked, however, the list is scrollable all way through.
yso-schreenshot-skosmos-scroll-problem-2020

@osma osma added the bug label Feb 1, 2021
@osma
Copy link
Member

osma commented Feb 1, 2021

Also affects LAJISTO in the same way. Only seems to happen on the vocabulary front page, not the alphabetical index page.

@osma
Copy link
Member

osma commented Feb 1, 2021

The AJAX style request to fetch the complete alphabetical index is not triggered at all on the vocabulary front page. There is no activity in the Network tab when scrolling to the bottom of the list - unlike on the index page where the request happens automatically. Tested both Firefox and Chromium.

@osma
Copy link
Member

osma commented Feb 1, 2021

I think the culprit is this line - the vocabulary home page loads the alphabetical index using AJAX style and patches in the HTML. The callback for loading more items (alphaWaypointCallback) isn't working properly (although the custom scrollbar is otherwise working) and the ajaxComplete callback only fixes this for some types of pages but not the vocabulary home page. Just removing the above mentioned if check seems to fix the problem, but it may have other, undesired side effects...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants