Automatically load rest of alphabetical index on vocabulary home page #1134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1108: it wasn't possible to scroll down to see the full alphabetical index of the first letter (typically A) on the vocabulary front page. The normal mechanism that triggers an AJAX request when scrolling down to the bottom of the first 250 results wasn't triggered on the vocabulary home page; it only worked on the alphabetical index page.
As analyzed in this comment the reason is that the callback for loading more lines isn't properly activated. The
if
check is too strict, it only works on theindex
page. I avoided theif
check altogether and simply targeted thesidebar-grey-alpha
CSS class, which is specific to the alphabetical index listings, instead of the more genericsidebar-grey
class.