Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid links to external URIs in non-mapping properties #935

Closed
osma opened this issue Feb 14, 2020 · 0 comments · Fixed by #944
Closed

Invalid links to external URIs in non-mapping properties #935

osma opened this issue Feb 14, 2020 · 0 comments · Fixed by #944
Assignees
Milestone

Comments

@osma
Copy link
Member

osma commented Feb 14, 2020

At which URL did you encounter the problem?

https://finto.fi/yse/en/page/Y382431

What steps will reproduce the problem?

  1. Go to above URL
  2. Click on the GitHub URL for the home page field

What is the expected output? What do you see instead?

Expected to get to the GitHub URL shown as the link text. Instead getting a page for an empty concept with the URL https://finto.fi/yse/en/page/?clang=fi&uri=https%3A%2F%2Fgithub.com%2FFinto-ehdotus%2FYSE%2Fissues%2F3173

This probably broke in the refactoring that was part of PR #921, in particular the use of ConceptPropertyValue instead of ConceptPropertyMappingValue for non-mapping properties (such as foaf:homepage in the above example)

@osma osma added this to the 2.4 milestone Feb 14, 2020
@osma osma self-assigned this Feb 14, 2020
osma added a commit that referenced this issue Mar 3, 2020
@osma osma closed this as completed in #944 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant