Fix problems displaying external links

[osma]

by more judicious use of isExternal and getExVocab. Fixes #935

ConceptMappingPropertyValue.isExternal() is removed because it is no longer being used.

[codecov]

Codecov Report

Merging #944 into master will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #944      +/-   ##
============================================
+ Coverage     58.27%   58.38%   +0.10%     
+ Complexity     1490     1486       -4     
============================================
  Files            32       32              
  Lines          4168     4162       -6     
============================================
+ Hits           2429     2430       +1     
+ Misses         1739     1732       -7     

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c769247...819bfaa. Read the comment docs.

[kouralex]

There is still this line

Skosmos/view/concept-shared.twig

Line 80 in c538175

{% if propval.isExternal %}

in twig template that still uses the old code that must be taken care of. Other than that, looks good!

[osma]

in twig template that still uses the old code that must be taken care of

This is as it should be. ConceptPropertyValue still has an isExternal method. It was only removed from ConceptMappingPropertyValue where it was not used anymore.

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells

No Coverage information
0.0% Duplication

[osma]

Scrutinizer reports bogus code duplication issues - not really a problem with the code.

SonarCloud reports code smells because of repeated literal strings in tests - not a problem and we have many of these already in the test suite.

[kouralex]

Now this looks good to me. The original case is solved and unnecessary code has been removed, great work!