-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displaying skos notation with a data type and label in the properties on the concept page #1198
Displaying skos notation with a data type and label in the properties on the concept page #1198
Conversation
…he concept page deleted
…es on the concept page if it is set up to be shown. A default value for showing the notation is 'true'
…ster the master branch
If you need test data... ...a datatype and label can be created like this: PREFIX skos: http://www.w3.org/2004/02/skos/core# INSERT DATA Adding a notation and datatype: INSERT DATA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave a few suggestions for improvements.
Also, unit tests are failing and that should be investigated. My guess is that this could have been caused by the changes to the SPARQL query, but it's hard to tell and needs to be tested locally.
…t only helps keep the code safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to look good, I gave a few comments for improvement.
…oved to the more reasonable location in the class
64ee912
to
05c55e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
============================================
- Coverage 68.26% 68.16% -0.11%
- Complexity 1609 1615 +6
============================================
Files 32 32
Lines 3955 3970 +15
============================================
+ Hits 2700 2706 +6
- Misses 1255 1264 +9
Continue to review full report at Codecov.
|
* Returns the boolean value of the skosmos:showNotationAsProperty setting. | ||
* @return boolean | ||
*/ | ||
public function getShowNotationAsProperty() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return type could be added as this is a new function via : bool
@@ -31,6 +34,17 @@ public function getLang() | |||
return $this->literal->getLang(); | |||
} | |||
|
|||
public function getDatatype() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring + return type missing
SonarCloud Quality Gate failed.
|
If a notation is shown in the properties on the concept page, also a datatype and datatype label are shown.
In the vocabulary config:
skosmos:showNotationAsProperty "true"; -> The notation in the properties is shown
skosmos:showNotationAsProperty "false"; -> The notation in the properties is not shown
commented: #skosmos:showNotationAsProperty "true"; -> The notation in the properties is shown