Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notation data type tests #1212

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Fix notation data type tests #1212

merged 2 commits into from
Sep 16, 2021

Conversation

osma
Copy link
Member

@osma osma commented Sep 16, 2021

A couple of minor fixes after merging PR #1198:

  • fix the coverage annotations (so that the test coverage is properly assessed for the getDatatype method)
  • change getDatatype to return null if a datatype exists without a label (and modify corresponding test)

ping @miguelahonen

@osma osma added this to the 2.12 milestone Sep 16, 2021
@osma osma self-assigned this Sep 16, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #1212 (15b1300) into master (c960e09) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1212      +/-   ##
============================================
+ Coverage     68.13%   68.36%   +0.22%     
  Complexity     1619     1619              
============================================
  Files            32       32              
  Lines          3973     3973              
============================================
+ Hits           2707     2716       +9     
+ Misses         1266     1257       -9     
Impacted Files Coverage Δ
model/ConceptPropertyValueLiteral.php 70.00% <100.00%> (+18.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c960e09...15b1300. Read the comment docs.

@osma
Copy link
Member Author

osma commented Sep 16, 2021

Hooray, coverage increased by 9 lines! (+0.22%)
Will merge.

@osma osma merged commit fbe2be0 into master Sep 16, 2021
@osma osma deleted the fix-notation-data-type-tests branch September 16, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant