Add support for PHP 8.1

[kouralex]

Reasons for creating this PR

Skosmos currently supports PHP versions 7.3 - 8.0 even though 7.3 EOL has already been reached and 7.4 is nearing its own end, see https://www.php.net/supported-versions.php. Therefore, there is a growing need of new version support.

Description of the changes in this PR

This PR straighforwardly fixes incompatibility issues (and deprecation notices) encountered whilst developing and testing Skosmos with PHP 8.1. I used the proposed solution described in #1274 (comment) to get past EasyRdf-related issues. Closes #1274

Known problems or uncertainties in this PR

• I was a bit uncertain about how to replace FILTER_SANITIZE_STRING (see https://www.php.net/manual/en/filter.filters.sanitize.php for more information, also see https://stackoverflow.com/questions/69207368/constant-filter-sanitize-string-is-deprecated and especially its accepted answer). It could be more appropriate to use the 3rd option of the accepted answer via a FILTER_CALLBACK, for example.
• I have not used a systematic approach (e.g., PHPStan) for checking out lingering issues in code base. This means that there may still reside some issues in the code base as the tests currently do not cover for everything. For instance, I discovered some not-so-apparent issues just by testing the autocomplete search, issues (deprecation) that did not appear whilst running the test kit.
• This PR does not address Raising a TypeError on method_exists() in PHP 8.x #1381

Checklist

• phpUnit tests pass locally with my changes
• I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
• The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
• The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Base: 71.35% // Head: 69.55% // Decreases project coverage by -1.81% ⚠️

Coverage data is based on head (417ae45) compared to base (b13b2c4).
Patch coverage: 42.30% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1385      +/-   ##
============================================
- Coverage     71.35%   69.55%   -1.81%     
  Complexity     1650     1650              
============================================
  Files            32       32              
  Lines          3774     4257     +483     
============================================
+ Hits           2693     2961     +268     
- Misses         1081     1296     +215     

Impacted Files	Coverage Δ
controller/RestController.php	22.85% <0.00%> (+0.58%)	⬆️
controller/WebController.php	15.59% <0.00%> (-1.73%)	⬇️
model/sparql/GenericSparql.php	92.52% <ø> (+1.24%)	⬆️
controller/Controller.php	57.36% <14.28%> (ø)
model/Request.php	71.91% <40.00%> (ø)
model/Concept.php	83.66% <100.00%> (-2.75%)	⬇️
model/ConceptSearchParameters.php	85.55% <100.00%> (ø)
model/Model.php	80.81% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[joelit]

Hooray for sweetrdf! Core functionalities need to be checked to be sure there are no regressions - I don't 100% trust the coverage of tests in this case.

[joelit]

Excellent work! :)

I gave this a thorough run-through, and here are my findings:

• EasyRDF seems to work fine
• Of the things not covered by PHPUnit, I tested that the update does not break the way Skosmos interacts with JS components like the JS tree or the search bar
• Finna-plugin seems to work too
• The new sanitation seems to work, seeing as the following special chars work with SPARQL
  • http://urn.fi/URN:NBN:fi:au:finaf:000083892
  • http://www.yso.fi/onto/yso/p8723
  • http://www.yso.fi/onto/yso/p13591

But there is something wrong with library dependencies to AssetCollection for robloach/component-installer:

Deprecation Notice: Return type of Assetic\Asset\AssetCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/AssetCollection.php:215
Deprecation Notice: Return type of Assetic\Filter\FilterCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Filter/FilterCollection.php:73
Deprecation Notice: Return type of Assetic\Filter\FilterCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Filter/FilterCollection.php:78
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionFilterIterator::getChildren() should either be compatible with RecursiveFilterIterator::getChildren(): ?RecursiveFilterIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionFilterIterator.php:80
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionFilterIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionFilterIterator.php:50
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionIterator::hasChildren() should either be compatible with RecursiveIterator::hasChildren(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionIterator.php:104
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionIterator::getChildren() should either be compatible with RecursiveIterator::getChildren(): ?RecursiveIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionIterator.php:112
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionIterator::current($raw = false) should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionIterator.php:54
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionIterator::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionIterator.php:89
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionIterator::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionIterator.php:84
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionIterator::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionIterator.php:99
Deprecation Notice: Return type of Assetic\Asset\Iterator\AssetCollectionIterator::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionIterator.php:94
Deprecation Notice: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/Skosmos/vendor/kriswallsmith/assetic/src/Assetic/Asset/Iterator/AssetCollectionIterator.php:40

Maybe the composer.json should change to https://github.com/oomphinc/composer-installers-extender or https://github.com/oomphinc/composer-installers-extender

[osma]

Excellent work! A couple of remarks on unit tests:

• I suggest merging the latest changes from master because the GitHub Actions CI tests were just fixed (PR Fix running git commands in CI tests under GitHub Actions #1397)
• PHP version matrix for unit tests should be adjusted in .github/workflows/ci.yml so that PHP 8.1 is no longer set as experimental (i.e. tests are no longer allowed to fail on 8.1)

[osma]

I'll see if I can finish this off.

[osma]

But there is something wrong with library dependencies to AssetCollection for robloach/component-installer:

This is caused by the components/handlebars.js package we are using. We have the latest released version (4.7.7), but the packaging for Composer uses the outdated robloach/component-installer package which depends on the also outdated kriswallsmith/assetic package that causes deprecation warnings on PHP 8.1 and will likely break on 8.2. There's not much we can do here except to switch away from the Composer package components/handlebars.js into something better maintained - if nothing else works, we could just include the handlebars.js code in this repo. I'll open a separate issue about this shortly.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.0% Duplication

[osma]

LGTM

[osma]

Reported the Handlebars.js dependency issue as #1401 .