Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden JSONP callback filter (Skosmos 3) #1554

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

osma
Copy link
Member

@osma osma commented Nov 22, 2023

Reasons for creating this PR

Same as PR #1553, but for Skosmos 3. See that PR for rationale and details.

Link to relevant issue(s), if any

Description of the changes in this PR

  • switch the input filter used for JSONP callback method names to FILTER_SANITIZE_FULL_SPECIAL_CHARS

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

(cherry picked from commit 33ef7e8)
@osma osma added the bug label Nov 22, 2023
@osma osma added this to the 3.0 milestone Nov 22, 2023
@osma osma self-assigned this Nov 22, 2023
@osma osma changed the base branch from master to skosmos-3 November 22, 2023 08:33
Copy link

sonarcloud bot commented Nov 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 34 Bugs
Vulnerability E 2 Vulnerabilities
Security Hotspot E 25 Security Hotspots
Code Smell A 401 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b4e41b4) 70.51% compared to head (66913be) 70.51%.

Files Patch % Lines
src/controller/RestController.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             skosmos-3    #1554   +/-   ##
============================================
  Coverage        70.51%   70.51%           
  Complexity        1643     1643           
============================================
  Files               32       32           
  Lines             4314     4314           
============================================
  Hits              3042     3042           
  Misses            1272     1272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma merged commit 71845bf into skosmos-3 Nov 22, 2023
6 of 9 checks passed
@osma osma deleted the fix-jsonp-callback-filter-skosmos3 branch November 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

1 participant