Adjust skosmos:showNotation setting to be obeyed in autocomplete dropdown #1393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Whilst working on #1380 (#1335), I noticed that the
skos:showNotation
setting is not respected in autocomplete dropdown. Whilst this is somewhat documented, I dare to say it could make more sense to have this setting enabled more globally, e.g., also in the autocomplete dropdown, too (as in all other places it is already respected in such a way).Description of the changes in this PR
This PR simply does not show the notation code if it is required to be hidden via
skosmos:showNotation "false"
setting.Known problems or uncertainties in this PR
This changes the way autocomplete search results are shown in, e.g., https://dev.finto.fi/yso-aika/fi/. This change of behavior may be a problem for that vocabulary, for example, in which case there should be another setting for this use case. As @joelit has created this vocabulary, I will set him as the reviewer of this PR so that he can make a good review of this problem and PR.
Checklist
.sr-only
class, color contrast)