Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust skosmos:showNotation setting to be obeyed in autocomplete dropdown #1393

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

kouralex
Copy link
Contributor

Reasons for creating this PR

Whilst working on #1380 (#1335), I noticed that the skos:showNotation setting is not respected in autocomplete dropdown. Whilst this is somewhat documented, I dare to say it could make more sense to have this setting enabled more globally, e.g., also in the autocomplete dropdown, too (as in all other places it is already respected in such a way).

Description of the changes in this PR

This PR simply does not show the notation code if it is required to be hidden via skosmos:showNotation "false" setting.

Known problems or uncertainties in this PR

This changes the way autocomplete search results are shown in, e.g., https://dev.finto.fi/yso-aika/fi/. This change of behavior may be a problem for that vocabulary, for example, in which case there should be another setting for this use case. As @joelit has created this vocabulary, I will set him as the reviewer of this PR so that he can make a good review of this problem and PR.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@kouralex kouralex added this to the Next Tasks milestone Nov 28, 2022
@kouralex kouralex requested a review from joelit November 28, 2022 15:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joelit joelit merged commit a22b389 into master Feb 9, 2023
@joelit joelit deleted the respect-show-notation-in-autocomplete branch February 9, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants