Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: generic-search - make results$ variable public in AbstractStarkSearchComponent #3082

Closed
SuperITMan opened this issue Nov 16, 2021 · 0 comments

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

It is not allowed to use results$ variable in template when extending AbstractStarkSearchComponent.

This variable contains the results of the search and can be used directly in template using | async pipe.

Expected behavior

This variable should be public.

What is the motivation / use case for changing the behavior?

Improve GenericSearch.

Environment


Angular version: 7.x
Stark version: 10.x & 12.x

@SuperITMan SuperITMan added this to the 10.2.4 milestone Nov 16, 2021
SuperITMan added a commit to SuperITMan/stark that referenced this issue Nov 17, 2021
SuperITMan added a commit to SuperITMan/stark that referenced this issue Nov 17, 2021
SuperITMan added a commit to SuperITMan/stark that referenced this issue Nov 17, 2021
SuperITMan added a commit to SuperITMan/stark that referenced this issue Nov 17, 2021
SuperITMan added a commit to SuperITMan/stark that referenced this issue Nov 17, 2021
@SuperITMan SuperITMan changed the title ui: GenericSearch - make results$ variable public in AbstractStarkSearchComponent ui: generic-search - make results$ variable public in AbstractStarkSearchComponent Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant