Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adapt generic search variables visibility stark12 #3085

Conversation

SuperITMan
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3082

results$ variable in AbstractStarkSearchComponent is protected and cannot be used in Angular templates.

What is the new behavior?

results$ variable in AbstractStarkSearchComponent is public and can be used in Angular templates.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

coveralls commented Nov 17, 2021

Coverage Status

Coverage remained the same at 88.202% when pulling b8ca98f on SuperITMan:feature/adapt-generic-search-variables-visibility-stark12 into f8bc759 on NationalBankBelgium:master.

@SuperITMan SuperITMan force-pushed the feature/adapt-generic-search-variables-visibility-stark12 branch 2 times, most recently from cfc5f82 to ef66611 Compare November 17, 2021 13:27
@SuperITMan SuperITMan force-pushed the feature/adapt-generic-search-variables-visibility-stark12 branch from ef66611 to b8ca98f Compare November 17, 2021 13:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SuperITMan SuperITMan merged commit ce0400d into NationalBankBelgium:master Nov 17, 2021
@SuperITMan SuperITMan deleted the feature/adapt-generic-search-variables-visibility-stark12 branch November 17, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants