Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly merge April 2024 #240

Merged
merged 35 commits into from
May 15, 2024
Merged

Monthly merge April 2024 #240

merged 35 commits into from
May 15, 2024

Conversation

slohse
Copy link
Contributor

@slohse slohse commented Apr 29, 2024

  • updated ngi_reports, taca, taca_ngi_pipeline to latest
  • updated CheckQC to v4.0.2
  • updated sequencing report service to v1.5.0
  • added nf-core/demultiplex to the deployment
  • added snpseq-metadata-service

aanil and others added 27 commits April 15, 2024 11:55
Update ngi_reports, taca, tac_ngi_pipeline to latest
instead of having separate folders for each pipeline
Co-authored-by: Matilda Åslin <matilda.aslin@medsci.uu.se>
@slohse slohse requested review from b97pla, aanil and FranBonath April 29, 2024 10:11
Copy link
Contributor

@b97pla b97pla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parts I know about (mainly snpseq-metadata) look good 👍

Copy link
Contributor

@FranBonath FranBonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you also update nf-core, would be good to add that to the list of updates, since it will warrant a verification.

@slohse
Copy link
Contributor Author

slohse commented Apr 29, 2024

Oh, good catch.
@Aratz, did you by any chance verify nf-core alongside seqreports?
Otherwise I guess we can't include it in this month's release,or can we?

@Aratz
Copy link
Contributor

Aratz commented Apr 29, 2024

No I did not. What is expected from such validation? Are there examples from older protocols?

The new nf-core version fixes nf-core/tools#2644, we can't have the new demultiplex pipeline if we don't update nf-core (although the service will still be able to run seqreports)

@matrulda
Copy link
Member

I would assume that successful deployments of the pipelines is verification enough?

@slohse
Copy link
Contributor Author

slohse commented May 15, 2024

Everything has been validated, merging 🚀

@slohse slohse merged commit 1b808f3 into main May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants