-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monthly merge April 2024 #240
Conversation
Update ngi_reports, taca, tac_ngi_pipeline to latest
instead of having separate folders for each pipeline
Co-authored-by: Matilda Åslin <matilda.aslin@medsci.uu.se>
Update sequencing report service
Updated checkQC version
Bump version of sequencing-report-service
Deploy snpseq metadata service
fix kong variable name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the parts I know about (mainly snpseq-metadata) look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you also update nf-core, would be good to add that to the list of updates, since it will warrant a verification.
Oh, good catch. |
No I did not. What is expected from such validation? Are there examples from older protocols? The new nf-core version fixes nf-core/tools#2644, we can't have the new demultiplex pipeline if we don't update nf-core (although the service will still be able to run seqreports) |
I would assume that successful deployments of the pipelines is verification enough? |
include nf-core pipeline version tag in path
specify full path to snpseq_metadata executable
…reboot DATAOPS-693 Remove hourly kong reboot
Everything has been validated, merging 🚀 |
snpseq-metadata-service