suppress deprecation warnings in generated code #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtrifonov
force-pushed
the
trifonov/javac-warnings-fix
branch
2 times, most recently
from
2b800fd
to
334b7bd
Compare
vtrifonov
force-pushed
the
trifonov/javac-warnings-fix
branch
from
334b7bd
to
fb4a91d
Compare
vmutafov
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1396
When extending a class SBG generates methods for all methods in the parent class including the deprecated ones, so to avoid those warnings we are are adding
@SuppressWarnings("deprecation")before the method declaration.A new setting is added which will cause the build to fail if there are any warnings in the generated code (excluding the autogenerated abstract deprecated methods from the SBG). The setting will be helpful if you want to check whether you are using deprecated methods when extending a class. To enable it add the following in the App_Resources/app.gradle file: