Don't copy generator .jar files to build-tools/ #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle complains that when multiple tasks have the same output path, it cannot decide accurately whether they need to run or not. The copyJarToBuildTools task of all three generators (android-dts-generator, android-metadata-generator, and static-binding-generator) shared the same output path, so they were always getting run. Instead, we can leave the .jar files in the location where they are built, and reference them from there in tasks that subsequently require them. This fix was submitted separately to android-dts-generator, which is a git submodule, in NativeScript/android-dts-generator#77 This commit pulls in a newer version of android-dts-generator which includes that fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle complains that when multiple tasks have the same output path, it cannot decide accurately whether they need to run or not. The copyJarToBuildTools task of all three generators (android-dts-generator, android-metadata-generator, and static-binding-generator) shared the same output path, so they were always getting run.
Instead, we can leave the .jar files in the location where they are built, and reference them from there in tasks that subsequently require them.
This fix was submitted separately to android-dts-generator, which is a git submodule, in NativeScript/android-dts-generator#77 This commit pulls in a newer version of android-dts-generator which includes that fix.
Related Pull Requests
NativeScript/android-dts-generator#77
Does your pull request have unit tests?
Should not need any new tests as this is just a Gradle build speedup. All existing tests should continue to pass.