Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy generator .jar files to build-tools/ #1789

Merged
merged 1 commit into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -261,19 +261,19 @@ task copyFilesToProjectTemeplate {
into "$DIST_FRAMEWORK_PATH/app/src/main/java/com/tns/internal"
}
copy {
from "$BUILD_TOOLS_PATH/static-binding-generator.jar"
from "$BUILD_TOOLS_PATH/static-binding-generator/build/libs/static-binding-generator.jar"
into "$DIST_FRAMEWORK_PATH/build-tools"
}
copy {
from "$BUILD_TOOLS_PATH/dts-generator.jar"
from "$BUILD_TOOLS_PATH/android-dts-generator/build/libs/dts-generator.jar"
into "$DIST_FRAMEWORK_PATH/build-tools"
}
copy {
from "$BUILD_TOOLS_PATH/jsparser/build/js_parser.js"
into "$DIST_FRAMEWORK_PATH/build-tools/jsparser"
}
copy {
from "$BUILD_TOOLS_PATH/android-metadata-generator.jar"
from "$BUILD_TOOLS_PATH/android-metadata-generator/build/libs/android-metadata-generator.jar"
into "$DIST_FRAMEWORK_PATH/build-tools"
}
copy {
Expand Down
4 changes: 2 additions & 2 deletions test-app/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ task runSbg(type: BuildToolTask) {
mainClass = "-jar"

def paramz = new ArrayList<String>()
paramz.add("static-binding-generator.jar")
paramz.add("static-binding-generator/build/libs/static-binding-generator.jar")

if (failOnCompilationWarningsEnabled()) {
paramz.add("-show-deprecation-warnings")
Expand Down Expand Up @@ -841,7 +841,7 @@ task buildMetadata(type: BuildToolTask) {
setOutputs outLogger

def paramz = new ArrayList<String>()
paramz.add("android-metadata-generator.jar")
paramz.add("android-metadata-generator/build/libs/android-metadata-generator.jar")

if(enableAnalytics){
paramz.add("analyticsFilePath=$analyticsFilePath")
Expand Down
3 changes: 0 additions & 3 deletions test-app/build-tools/.gitignore
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
static-binding-generator.jar
sbg-bindings.txt
sbg-interface-names.txt
sbg-js-parsed-files.txt
sbg-input-file.txt
sbg-output-file.txt
sbg-java-dependencies.txt
android-metadata-generator.jar
mdg-output-dir.txt
mdg-java-dependencies.txt
dts-generator.jar
sbg-input-output-dirs.txt
mdg-java-out.txt
10 changes: 0 additions & 10 deletions test-app/build-tools/android-metadata-generator/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,3 @@ jar {

duplicatesStrategy = 'include'
}

task copyJarToBuildTools (type: Copy) {
from "$projectDir/build/libs/android-metadata-generator.jar"
into "$projectDir/../"
}

jar.finalizedBy(copyJarToBuildTools)



11 changes: 0 additions & 11 deletions test-app/build-tools/static-binding-generator/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,9 @@ dependencies {
}

compileJava {
if (!findProject(':dts-generator').is(null)) {
dependsOn ':dts-generator:copyJarToBuildTools'
}
options.compilerArgs << "-Xlint:all" << "-Xlint:-options" << "-Werror"
}

task copyJarToBuildTools (type: Copy) {
inputs.file("$projectDir/build/libs/static-binding-generator.jar")
from "$projectDir/build/libs/static-binding-generator.jar"
into "$projectDir/../"
}

jar {

configurations.implementation.setCanBeResolved(true)
Expand Down Expand Up @@ -72,5 +63,3 @@ jar {

duplicatesStrategy = 'include'
}

jar.finalizedBy(copyJarToBuildTools)
13 changes: 2 additions & 11 deletions test-app/build-tools/static-binding-generator/runtests.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,7 @@ jar {
duplicatesStrategy = 'include'
}

task copyJar(dependsOn: 'jar') {
doFirst {
def source = file("$projectDir/build/libs/static-binding-generator.jar").toPath()
print source.toFile().exists()
def dest = file("$projectDir/../static-binding-generator.jar").toPath()
Files.copy(source, dest, StandardCopyOption.REPLACE_EXISTING)
}
}

task prepareInputFiles(dependsOn: 'copyJar') {
task prepareInputFiles {
doFirst {
inputFile.write(appRoot)
outputFile.write(generatedJavaClassesRoot.toString())
Expand All @@ -77,7 +68,7 @@ task prepareInputFiles(dependsOn: 'copyJar') {
}

task runSbg(type: JavaExec, dependsOn: 'prepareInputFiles') {
classpath = files('../static-binding-generator.jar', '../')
classpath = files('build/libs/static-binding-generator.jar', '../')
workingDir = "../"
main = "org.nativescript.staticbindinggenerator.Main"
}
Expand Down
Loading