Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New include path format #310

Closed
cpsauer opened this issue Nov 13, 2023 · 5 comments
Closed

New include path format #310

cpsauer opened this issue Nov 13, 2023 · 5 comments
Assignees
Milestone

Comments

@cpsauer
Copy link
Contributor

cpsauer commented Nov 13, 2023

Hi @Neargye! Thanks again for a wonderful library.

I was looking at eb867ec: is the intent to have users #include "magic_enum/..." (like for Bazel) or #include "magic_enum.hpp", (like in the cmake config)?

Either seems totally reasonable, but I happened across the inconsistency when updating (and needing to change my includes), so I figured you might want a friendly heads.

Thanks for all you do,
Chris

@Neargye
Copy link
Owner

Neargye commented Nov 13, 2023

Hi,
I think #include "magic_enum.hpp", I'll try to quickly fix it.
Thanks for catch and create issues

@Neargye Neargye added this to the v0.9.5 milestone Nov 13, 2023
@Neargye Neargye self-assigned this Nov 13, 2023
@Neargye
Copy link
Owner

Neargye commented Nov 13, 2023

It seemed to me that I had configured this correctly in cmake this way #include "magic_enum.hpp", but with so many build systems I’m already a little confused, could you tell me where I'm wrong?

cpsauer added a commit to cpsauer/magic_enum that referenced this issue Nov 13, 2023
@cpsauer
Copy link
Contributor Author

cpsauer commented Nov 13, 2023

Sorry--I wrote the path <-> build systems mappings backwards above, but they are indeed inconsistent. (Have edited the original post so I don't confuse any future readers, but it was previously wrong.)

So to confirm: cmake is as you want, #include "magic_enum.hpp". I'm seeing you made the parallel change for meson in 3c92e90. I've tossed up a quick PR #311 to make things consistent for Bazel (which is what I'm using and why I noticed). On a quick look, it seemed like those were all the build systems; if that's right #311 should resolve!

Thanks again for making a stupendous library and sharing it with the world!

Neargye pushed a commit that referenced this issue Nov 14, 2023
@Neargye Neargye closed this as completed Nov 14, 2023
@Neargye
Copy link
Owner

Neargye commented Nov 14, 2023

Thanks for your help!

@cpsauer
Copy link
Contributor Author

cpsauer commented Nov 14, 2023

My pleasure. Thanks again for being so great to work with, Daniil, and for putting in the work to share such a great library with the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants