Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: Make include directories consistent #311

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

cpsauer
Copy link
Contributor

@cpsauer cpsauer commented Nov 13, 2023

Parallel to
3c92e90 eb867ec

Addresses Bazel part of #310

@zaucy
Copy link
Contributor

zaucy commented Nov 14, 2023

Dang! Down side to the bazel CI be continue-on-error. Would've been caught before release. https://github.com/Neargye/magic_enum/actions/runs/6836609904/job/18591721634#step:5:46

@cpsauer
Copy link
Contributor Author

cpsauer commented Nov 14, 2023

^ Might it be worth changing that?

Also, if we can get to quick agreement on #312, we might want to skip merging this to avoid the unnecessary conflict. So maybe let's see if we can get #312 in by Wednesday and if not, we'll merge this?

@Neargye
Copy link
Owner

Neargye commented Nov 14, 2023

Removed continue-on-error in CI

@Neargye Neargye merged commit 3437129 into Neargye:master Nov 14, 2023
18 checks passed
@Neargye Neargye added this to the v0.9.5 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants