Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComponentConfig not representing the features of Keycloak Component #321

Open
doktormerlin opened this issue Nov 15, 2021 · 0 comments
Open

ComponentConfig not representing the features of Keycloak Component #321

doktormerlin opened this issue Nov 15, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@doktormerlin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
ComponentConfig currently only supports "Algorithm" and "Priority" attributes, while components seem to be a generic type with multiple different uses that need a lot more versatility. e.g. creating a user-federation uses the ComponentConfig with multiple fields to control the federation which is not possible to create with GoCloak

Describe the solution you'd like
ComponentConfig should be a generic type where you can set a JSON string to your likes

Describe alternatives you've considered
An alternative would be to create different types of ComponentConfig depending on the Component you want to create.

Additional context
@Nerzal Nerzal added the enhancement New feature or request label Nov 17, 2021
@doktormerlin doktormerlin mentioned this issue Nov 19, 2021
Merged
Nerzal pushed a commit that referenced this issue Feb 17, 2022
@doktormerlin
Changed ComponentConfig to be a map[string][]string instead of its ow…
4716d38 
…n struct (#325)

* Feature: #321 ComponentConfig now is a map[string]string to generalize it's usage

* changed module name

* changed all nerzal to doktormerlin

* added replacement directive

* Added newline to end of file

* removed replacement directive

* map[string]string now map[string][]string in ComponentConfig

* Changed ComponentConfig to be a map[string][]string instead of its own struct

* Fixed issues caused by renaming. Go and forking just doesnt go well together

* Renamed some stuff from Nerzal to nerzal

* tests sleeping 10 seconds again

* reverted tests

Co-authored-by: merl_umlaut <merlin.dienst@umlaut.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nerzal @doktormerlin