Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ComponentConfig to be a map[string][]string instead of its own struct #325

Merged
merged 13 commits into from
Feb 17, 2022

Conversation

doktormerlin
Copy link
Contributor

Covers issue #321

@doktormerlin
Copy link
Contributor Author

In this PR I changed the existing ComponentConfig which would be a breaking change. Another possibility would be to create a second Component, GenericComponent or something like this, that would use map[string][]string as its ComponentConfig. However, since Keycloak Components are meant to be a generic type I think it makes more sense to always use map[string][string].

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #325 (89825f5) into main (e1f4448) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   76.59%   76.59%           
=======================================
  Files           4        4           
  Lines        1961     1961           
=======================================
  Hits         1502     1502           
  Misses        319      319           
  Partials      140      140           
Impacted Files Coverage Δ
models.go 92.75% <ø> (-0.06%) ⬇️
client.go 74.80% <100.00%> (ø)
utils.go 97.50% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c8e11...89825f5. Read the comment docs.

Copy link
Owner

@Nerzal Nerzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thank you for the contribution

I'll create a new release as soon as i merged all PRs, that are on my List.
Will hapen this week!

@Nerzal Nerzal merged commit 4716d38 into Nerzal:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants