Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Race condition between run() and timeout #189

Merged
merged 2 commits into from
Oct 2, 2013
Merged

BugFix: Race condition between run() and timeout #189

merged 2 commits into from
Oct 2, 2013

Conversation

benjchristensen
Copy link
Contributor

This uses compareAndSet to synchronize timeout vs run() completion logic when there is a race.

I have not been able to to replicate the issue reported at #188 but I can see how the existing code is vulnerable to a race condition. This theoretically should fix it. All unit tests pass for existing functionality. All my attempts to create a unit test to reveal the issue failed.

This uses compareAndSet to synchronize timeout vs run() completion logic when there is a race.

I have not been able to to replicate the issue reported at #188 but I can see how the existing code is vulnerable to a race condition. This theoretically should fix it. All unit tests pass for existing functionality. All my attempts to create a unit test to reveal the issue failed.
@cloudbees-pull-request-builder

Hystrix-pull-requests #52 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

Hystrix-pull-requests #53 FAILURE
Looks like there's a problem with this pull request

benjchristensen added a commit that referenced this pull request Oct 2, 2013
BugFix: Race condition between run() and timeout
@benjchristensen benjchristensen merged commit a49e70b into Netflix:master Oct 2, 2013
@benjchristensen benjchristensen deleted the issue-188 branch October 2, 2013 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants