Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Race condition between run() and timeout #189

Merged
merged 2 commits into from
Oct 2, 2013
Merged

BugFix: Race condition between run() and timeout #189

merged 2 commits into from
Oct 2, 2013

Commits on Oct 1, 2013

  1. BugFix: Race condition between run() and timeout 

    This uses compareAndSet to synchronize timeout vs run() completion logic when there is a race.

I have not been able to to replicate the issue reported at #188 but I can see how the existing code is vulnerable to a race condition. This theoretically should fix it. All unit tests pass for existing functionality. All my attempts to create a unit test to reveal the issue failed.
    @benjchristensen
    benjchristensen committed Oct 1, 2013
    Configuration menu
    Copy the full SHA
    35fb8ce View commit details
    Browse the repository at this point in the history

  2. Protecting against timeout race-condition for error handling.

    @benjchristensen
    benjchristensen committed Oct 1, 2013
    Configuration menu
    Copy the full SHA
    d37d8c5 View commit details
    Browse the repository at this point in the history