Favor timeout property that is not thread-specific. (execution.timeoutInMilliseconds)

[mattrjacobs]

Also deprecate usages of thread-specific setting (like execution.thread.isolation.timeoutInMilliseconds).

This addresses #300

[cloudbees-pull-request-builder]

NetflixOSS » Hystrix » Hystrix-pull-requests #30 SUCCESS
This pull request looks good

[holy12345]

Hi @mattrjacobs
I have a question want your confirmation.
In the PR you submitted I saw an addition of an execution.timeoutInMilliseconds property, which represents the timeout period (regardless of whether the isolation strategy is semaphore or thread).
I understand that this change can be seen in 1.4RC or later.

But my current version is 1.5.12. The execution.timeoutInMilliseconds property does not exist.

I saw the following code in HystrixCommandProperties

 //this property name is now misleading. //TODO figure out a good way to deprecate this property name
this.executionTimeoutInMilliseconds = getProperty(propertyPrefix, key, "execution.isolation.thread.timeoutInMilliseconds", builder.getExecutionIsolationThreadTimeoutInMilliseconds(), default_executionTimeoutInMilliseconds);

By javadoc and my local validation I got the following conclusion:

• In the 1.5.12 version we did not execute.timeoutInMilliseconds this parameter.

• Currently we are still using execution.isolation.thread.timeoutInMilliseconds to represent the timeout (regardless of whether the isolation strategy is semaphore or thread, as javadoc said, the name of this parameter is confusing)

Am i right? Looking forward to your reply. Thanks again, best wishes