Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate execution.isolation.thread.timeoutInMIlliseconds property name in favor of execution.timeoutInMilliseconds #673

Closed
mattrjacobs opened this issue Feb 12, 2015 · 8 comments
Milestone

Comments

@mattrjacobs
Copy link
Contributor

Given change in #664, make sure that both styles of naming the timeout property work, and setting both chooses the new-style

@mattrjacobs
Copy link
Contributor Author

I still want to do this feature, but the revert in #675 makes it not critical for 1.4.0. Will push to 1.4.x

@mattrjacobs mattrjacobs added this to the 1.4.x milestone Feb 13, 2015
@mattrjacobs mattrjacobs changed the title Unit test of both styles of naming timeout property Deprecate execution.isolation.thread.timeoutInMIlliseconds property name in favor of execution.timeoutInMilliseconds Feb 13, 2015
@mattrjacobs mattrjacobs modified the milestones: Hystrix-core Features, 1.4.x Mar 27, 2015
@mattrjacobs mattrjacobs removed this from the Hystrix-core Features milestone Aug 3, 2015
@mattrjacobs mattrjacobs added this to the 1.5.x milestone Aug 3, 2015
@mattrjacobs mattrjacobs modified the milestones: 2.0.x, 1.5.x Jan 14, 2016
@dmak
Copy link

dmak commented Jun 21, 2017

closed = the new property will not get into master? Or is it already in 2.0.x branch?

@mattrjacobs
Copy link
Contributor Author

Both properties are in master. 2.x branch is not active at this point

@dmak
Copy link

dmak commented Jul 3, 2017

@mattrjacobs As far as I can see the original commit 60e47c1 was reverted by a2c5112 on 15 Feb 2015. The code in master reads the property execution.isolation.thread.timeoutInMilliseconds, see HystrixCommandProperties:123. Please forgive me if I have missed something... maybe you could point me the line where execution.timeoutInMilliseconds property is read? Thanks!

@mattrjacobs
Copy link
Contributor Author

@dmak Apologies - you are correct. The property is only configurable via the key execution.isolation.thread.timeoutInMilliseconds in master.

@dmak
Copy link

dmak commented Jul 7, 2017

Then the questions is still opened: in what Hystrix version will this fix be available?

@mattrjacobs
Copy link
Contributor Author

As of right now, no one is working on it.

@dmak
Copy link

dmak commented Jul 12, 2018

Then this ticket should be re-opened, because the support of execution.timeoutInMilliseconds property is not applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants