Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hystrix configuration #115

Closed
luan-cestari opened this issue Mar 13, 2015 · 3 comments
Closed

Fix Hystrix configuration #115

luan-cestari opened this issue Mar 13, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@luan-cestari
Copy link
Collaborator

Found strange behavior case when the commands were taking more than one second to respond and after looking into the Hystrix documentation (which was outdated Netflix/Hystrix#714 ) and code I understood that Hystrix changed its default behavior. After search more a bit found the https://github.com/Netflix/Hystrix/blob/master/CHANGELOG.md that make it clear that now even semaphore isolation strategy will timeout. I opened an issue Netflix/Hystrix#714 asking if they could update the documentation and even change that property name and they are working on it. On meanwhile, we need to make sure that every project that relys on Hystrix have its configuration file with https://github.com/Netflix/Hystrix/wiki/Configuration#execution.isolation.thread.timeoutInMilliseconds property with the reasonable amount of time that you would expect that after that threshold it should fire a time out exception from Hystrix. (Note: so this also apply for our puppet scripts that may need to specify the timeout parameter as well) .

@jewzaam
Copy link
Member

jewzaam commented Mar 16, 2015

Nice find, I added issues to ldap and mongo, as they use this isolation strategy for tests as well.

@luan-cestari
Copy link
Collaborator Author

Thanks. I think they will also rename that property, so It would be nice that we leave at least one issue one about this to make sure that we have the right property set (as we can get a newer version during lightblue release and have a similar problem once again)

@jewzaam jewzaam added this to the Ana milestone Mar 16, 2015
@jewzaam jewzaam added the ready label Mar 16, 2015
@jewzaam jewzaam mentioned this issue Mar 18, 2015
@jewzaam jewzaam assigned jewzaam and unassigned luan-cestari Mar 18, 2015
luan-cestari added a commit that referenced this issue Mar 18, 2015
Fixes #115: set timeout for semaphore strategy
@luan-cestari
Copy link
Collaborator Author

The issue in Hystrix about the renaming -> Netflix/Hystrix#673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants