-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hystrix configuration #115
Comments
Nice find, I added issues to ldap and mongo, as they use this isolation strategy for tests as well. |
Thanks. I think they will also rename that property, so It would be nice that we leave at least one issue one about this to make sure that we have the right property set (as we can get a newer version during lightblue release and have a similar problem once again) |
Fixes #115: set timeout for semaphore strategy
The issue in Hystrix about the renaming -> Netflix/Hystrix#673 |
Found strange behavior case when the commands were taking more than one second to respond and after looking into the Hystrix documentation (which was outdated Netflix/Hystrix#714 ) and code I understood that Hystrix changed its default behavior. After search more a bit found the https://github.com/Netflix/Hystrix/blob/master/CHANGELOG.md that make it clear that now even semaphore isolation strategy will timeout. I opened an issue Netflix/Hystrix#714 asking if they could update the documentation and even change that property name and they are working on it. On meanwhile, we need to make sure that every project that relys on Hystrix have its configuration file with https://github.com/Netflix/Hystrix/wiki/Configuration#execution.isolation.thread.timeoutInMilliseconds property with the reasonable amount of time that you would expect that after that threshold it should fire a time out exception from Hystrix. (Note: so this also apply for our puppet scripts that may need to specify the timeout parameter as well) .
The text was updated successfully, but these errors were encountered: