Ldap log#116 #117
Merged
Ldap log#116 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +84,7 @@ This methods is executed for all types of failure such as run() failure, timeout | |||
| */ | |||
| @Override | |||
| protected SearchResult getFallback() { | |||
| LOGGER.info("Error during the execution of the command. Falling back to the cache"); | |||
| LOGGER.error("Error during the execution of the command. Falling back to the cache"); | |||
There was a problem hiding this comment.
Should we log this at error level or something lower, maybe warn? Because we have a fallback, seems it could be a warning and if the fallback fails we'd have an error.
There was a problem hiding this comment.
Agree. I will switch to warn level . At the first sight I thought this would not impact being this way but as it can have a heavy load it could wast a lot of space and cpu .
|
Build failing, maybe because of #115 |
|
rebuilding after the PR been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue #116