-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #116 - Ldap integration test #119
Fixes #116 - Ldap integration test #119
Conversation
…es on LDAP. One test is in progress due problems to insert an object into the embedded LDAP server
…es on LDAP. One test is in progress due problems to insert an object into the embedded LDAP server
Fixed some log dependency issues. Fixed the possible problem with cache that we found (but we didn't get evidences of the root cause). It need to finsih an unit test but I don't have enough knowledge about LDAP and Apache DS API, if someone could help with that, I can update this PR |
The unit test remaining just need to create a valid object into LDAP server to be queried |
@luan-cestari does this fix #116? And is there any more work to do before review? Your last comment makes me think something needs done with a unit test still. |
@jewzaam it probably solve it as we don't have enough data about the issue, so I wouldn't guarantee it solves the problem. The remaining test is something good to have, I ping some people on the channel for help, I think Derek is working on it. |
try { | ||
userRoles.addAll(getUserRolesFromCache(userName)); | ||
List<String> userRolesFromCache = getUserRolesFromCache(userName); | ||
if( userRolesFromCache != null && userRolesFromCache.isEmpty() ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Condition should be !userRolesFromCache.isEmpty()
(missing !)
I'll merge after condition for using roles from cache is update. |
Missed the '!' on line 66. Now it is correct: if( userRolesFromCache != null && !userRolesFromCache.isEmpty() ) {
Fixed the line commented by @jewzaam |
Fixes #116 - Ldap integration test
Related to this issue #116 (this PR also incorporate the changes of #117 )