Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wiki #714

Closed
luan-cestari opened this issue Mar 13, 2015 · 5 comments
Closed

Update wiki #714

luan-cestari opened this issue Mar 13, 2015 · 5 comments

Comments

@luan-cestari
Copy link

The wiki page https://github.com/Netflix/Hystrix/wiki/Configuration#execution.isolation.thread.timeoutInMilliseconds should be updated with the information about 1.4.x (https://github.com/Netflix/Hystrix/blob/master/CHANGELOG.md) (in summary, timeout now applies for semaphores as well). I would also recommend to rename that property (as it mislead to think it only applies to thread isolation as it used to be)

@DavidMGross
Copy link

I've fixed the wiki description, but am leaving the issue open to consider the renaming proposal.

@luan-cestari
Copy link
Author

Thanks @DavidMGross

@mattrjacobs
Copy link
Contributor

@luan-cestari I agree on the naming. I've already got an open issue to deprecate the old name and move Hystrix consumers to the new name here: #673

@luan-cestari
Copy link
Author

@mattrjacobs cool =) So we can close this issue (as teh wiki is updated and there is already an issue for the renaming ) right?

Thank you very much guys, it was awesome work you guys did creating and maintaining Hystrix. Also, thank you very much for the fast reply and consideration of the issue opened by someone which is not part of the team =)

Let me know if I can help with a minor issue or something else.

@infomaven
Copy link

I've enjoyed following all the discussions on this topic. Learned a lot of new things about Hystrix.
Thanks for your diligence and attention to detail on this task. I'm sure it will help lots of people!

Date: Wed, 25 Mar 2015 19:21:55 -0700
From: notifications@github.com
To: Hystrix@noreply.github.com
Subject: Re: [Hystrix] Update wiki (#714)

@mattrjacobs cool =) So we can close this issue (as teh wiki is updated and there is already an issue for the renaming ) right?

Thank you very much guys, it was awesome work you guys did creating and maintaining Hystrix. Also, thank you very much for the fast reply and consideration of the issue opened by someone which is not part of the team =)

Let me know if I can help with a minor issue or something else.


Reply to this email directly or view it on GitHub.

billybong pushed a commit to billybong/Hystrix-wiki that referenced this issue Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants