Associate Signals w/ Workflows and add UI elements to bind them in Definition and run in Instance tab #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
commented
Mar 15, 2023
wssheldon
commented
Mar 15, 2023
wssheldon
commented
Mar 15, 2023
src/dispatch/database/revisions/tenant/versions/2023-03-14_b48b245f9c4c.py
Outdated
Show resolved
Hide resolved
wssheldon
commented
Mar 15, 2023
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…finition and run in Instance tab (Netflix#3116) * Add a child component for our Combobox called Basecombobox * Create a WorkflowCombobox that uses the BaseCombobox * Add a workflow run button the signalInstanceTab that uses RunModal * add spaces around Signals tab key text for consistency * Add WorkflowCombobox to SignalDefinition edit sheet * associate workflows with signals * remove console.log() * remove console.log() * remove service table from migration file * add get_by_name_or_raise to Workflow service and implment them in signal update/create * remove entity_search operations from alembic migration
rutvijmehta-harness
added a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…finition and run in Instance tab (Netflix#3116) (#98) * Add a child component for our Combobox called Basecombobox * Create a WorkflowCombobox that uses the BaseCombobox * Add a workflow run button the signalInstanceTab that uses RunModal * add spaces around Signals tab key text for consistency * Add WorkflowCombobox to SignalDefinition edit sheet * associate workflows with signals * remove console.log() * remove console.log() * remove service table from migration file * add get_by_name_or_raise to Workflow service and implment them in signal update/create * remove entity_search operations from alembic migration Co-authored-by: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the smallest unit of work on this iteration towards parameterized workflow/notebook creation via signal instance entities. This PR associates workflows with Signals, supports that association on the frontend via the definition edit sheet, and allows you to run arbitrary workflows from a SignalInstance in the tab.