Associate Signals w/ Workflows and add UI elements to bind them in Definition and run in Instance tab (#3116) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finition and run in Instance tab (Netflix#3116) * Add a child component for our Combobox called Basecombobox * Create a WorkflowCombobox that uses the BaseCombobox * Add a workflow run button the signalInstanceTab that uses RunModal * add spaces around Signals tab key text for consistency * Add WorkflowCombobox to SignalDefinition edit sheet * associate workflows with signals * remove console.log() * remove console.log() * remove service table from migration file * add get_by_name_or_raise to Workflow service and implment them in signal update/create * remove entity_search operations from alembic migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a child component for our Combobox called Basecombobox
Create a WorkflowCombobox that uses the BaseCombobox
Add a workflow run button the signalInstanceTab that uses RunModal
add spaces around Signals tab key text for consistency
Add WorkflowCombobox to SignalDefinition edit sheet
associate workflows with signals
remove console.log()
remove console.log()
remove service table from migration file
add get_by_name_or_raise to Workflow service and implment them in signal update/create
remove entity_search operations from alembic migration