Fix maven missing deps: upgrade nebula + gradle #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
calvin681,
sundargates,
hmitnflx and
fdc-ntflx
as code owners
hmitnflx
approved these changes
Jul 18, 2024
| @@ -104,9 +105,8 @@ project.snapshot.configure { finalizedBy printAllReleasedArtifacts } | |||
| subprojects { | |||
| apply plugin: 'java-library' | |||
There was a problem hiding this comment.
How about we add explicit dep on jar task for control-plane project here in subprojects block instead of adding to individual projects.
There was a problem hiding this comment.
This is a specific handling between control-plane-core etc. and it feels a bit too generic to add these rules for all sub-proj?
| allprojects { | ||
| apply plugin: 'com.palantir.baseline-idea' | ||
| } | ||
| // allprojects { |
There was a problem hiding this comment.
delete altogether instead of commenting?
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Test Results535 tests 529 ✅ 7m 45s ⏱️ Results for commit c7c92f1. ♻️ This comment has been updated with latest results. |
hmitnflx
approved these changes
Jul 19, 2024
build.gradle
Outdated
| @@ -27,7 +27,7 @@ buildscript { | |||
| dependencies { | |||
| classpath 'com.netflix.nebula:gradle-netflixoss-project-plugin:11.5.0' | |||
| classpath 'com.netflix.nebula:nebula-dependency-recommender:11.+' | |||
| classpath 'io.mantisrx:mantis-gradle-plugin:1.2.6-rc.3' | |||
| classpath 'io.mantisrx:mantis-gradle-plugin:1.2.6-rc.4' | |||
There was a problem hiding this comment.
nit: Pl consider using a release version instead of a candidate.
There was a problem hiding this comment.
yeha will switch once this is fully fixed. (it's an open pr on the other side).
There was a problem hiding this comment.
(currently blocked due to gradle plugin repo publish failure).
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
force-pushed
the
andyz/fixMavenMissingDeps
branch
from
987bfc8
to
dc3f53a
Compare
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Uploaded ArtifactsTo use these artifacts in your Gradle project, paste the following lines in your build.gradle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To fix the removed maven dependencies, the Nebula oss version + gradle version needs to be updated.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests