Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constantinople progress #93

Closed
5 tasks done
tkstanczak opened this issue Sep 18, 2018 · 3 comments
Closed
5 tasks done

Constantinople progress #93

tkstanczak opened this issue Sep 18, 2018 · 3 comments

Comments

@tkstanczak
Copy link
Member

tkstanczak commented Sep 18, 2018

EIPs included in Constantinople:

@tkstanczak
Copy link
Member Author

implemented with tests wherever provided in spec, need to review the new blockchain tests in ethereum/test (assuming that the new opcodes are covered there extensively)

1283 - implementation uses some additional memory now to store original values, which can be improved by exposing first elements from change stacks in StorageProvider (either by using different data structure or by writing own stack implementation as the .NET stack only exposes peek and pop/push

@tkstanczak
Copy link
Member Author

CREATE2 spec gives some options so need to confirm which one was implemented in other clients (should be enough to run etheruem/tests)

@tkstanczak
Copy link
Member Author

difficulty bomb delay not tested so will only be tested with ethereum/tests

  • add basic difficulty tests directly in Nethermind tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@tkstanczak and others