Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constantinople Progress Tracker #53

Closed
Souptacular opened this issue Jul 30, 2018 · 68 comments
Closed

Constantinople Progress Tracker #53

Souptacular opened this issue Jul 30, 2018 · 68 comments

Comments

@Souptacular
Copy link
Contributor

Souptacular commented Jul 30, 2018

This issue is meant to track the progress of client implementation and tests of the EIPs for the upcoming Constantinople hard fork.

Migrated to https://github.com/ethereum/pm/wiki/Constantinople-Progress-Tracker

Test Cases Spreadsheet

@carver
Copy link

carver commented Jul 30, 2018

Trinity Constantinople Milestone: https://github.com/ethereum/py-evm/milestone/2

@5chdn
Copy link
Contributor

5chdn commented Jul 31, 2018

Parity Ethereum:

Did we decide to drop EIP-210? openethereum/parity-ethereum#5505

@jbaylina
Copy link

Is EIP-1108 and EIP-1109 going to be included in Constantinople ?

@axic
Copy link
Member

axic commented Jul 31, 2018

Progress tracker for ethereumjs: ethereumjs/ethereumjs-monorepo#322

@ayrat555
Copy link

ayrat555 commented Aug 1, 2018

Mana progress: mana-ethereum/mana#307

@pipermerriam
Copy link
Member

pipermerriam commented Aug 1, 2018

@pipermerriam
Copy link
Member

Trinity: Here is the issue link for EIP1052

ethereum/py-evm#719

@mkalinin
Copy link
Contributor

mkalinin commented Aug 7, 2018

EthereumJ: ethereum/ethereumj#1149

@cburgdorf
Copy link

@Souptacular you can check EIP 145 for Trinity. It's implemented in ethereum/py-evm#1134 and ethereum/py-evm#1112 which are both merged in latest master

@cburgdorf
Copy link

@Souptacular and EIP1052 landed in Trinity as well ethereum/py-evm#1147

@Souptacular
Copy link
Contributor Author

Updated!

@holgerd77
Copy link

Can we eventually add progress on the test cases written in https://github.com/ethereum/tests to the progress tracker, maybe with the number of implemented/merged test cases on the column for an EIP? @winsvega?

Have absolutely no overview on the current state there.

In this context I just rediscovered this test cases collection spreadsheet for Metropolis, is this still updated/cared for or is there an alternative collection like this existing?

@winsvega
Copy link

winsvega commented Aug 9, 2018

yes. that google list is tracking new tests since before Metropolis. It is being updated.

@holgerd77
Copy link

@winsvega Ah great, would be really good if you guys can keep the doc as up-to-date as possible and also make it clear which tests are implemented and where to find the implementation (like being done in the RETURN CODES sheet e.g.). This really helps us a lot on the implementation side!

@chfast
Copy link
Member

chfast commented Aug 10, 2018

cpp-ethereum / EXTCODEHASH implemented.

@cburgdorf
Copy link

We implemented CREATE2 in Trinity. I will add that in contrast to the other new opcodes though, this one hasn't received much testing yet

ethereum/py-evm#1186

@zilm13
Copy link

zilm13 commented Aug 24, 2018

EthereumJ/Harmony:
EIP 145: Bitwise shifting instructions in EVM implemented
EIP 1052: EXTCODEHASH Opcode implemented
everything else in progress

@chfast
Copy link
Member

chfast commented Aug 31, 2018

Aleth / EIP 1283 done: ethereum/aleth#5231

@5chdn
Copy link
Contributor

5chdn commented Aug 31, 2018

Parity Ethereum / EIP-1234 in progress openethereum/parity-ethereum#9187

@lrettig
Copy link
Contributor

lrettig commented Sep 6, 2018

Added EIP-1234 to the tracker

@gumb0
Copy link
Member

gumb0 commented Sep 6, 2018

Aleth / EIP-1234 done ethereum/aleth#5247

@nateawelch
Copy link

Can the links to 145/1014 be updated to point to their respective eips.ethereum.org page? 1014 points to the pull request, which makes it difficult for people unfamiliar with git to read it.

@5chdn
Copy link
Contributor

5chdn commented Sep 8, 2018

Parity Ethereum merged EIP-1283 openethereum/parity-ethereum#9319

Parity Ethereum PR for EIP-1234 is openethereum/parity-ethereum#9480 now (merged)

Parity Ethereum is feature-complete. openethereum/parity-ethereum#9505

@ayrat555
Copy link

Mana implemented EIP-145 mana-ethereum/mana#417

@ayrat555
Copy link

EIP 1234 is merged in Mana mana-ethereum/mana#447

@mkalinin
Copy link
Contributor

mkalinin commented Oct 5, 2018

EthereumJ. CREATE2 gas price update merged ethereum/ethereumj#1204

@5chdn
Copy link
Contributor

5chdn commented Oct 8, 2018

@ajsutton
Copy link

I'm happy to add that Pantheon has added support for all the Constantinople EIPs, including the updated CREATE2 spec.

@holgerd77
Copy link

EthereumJS:
CREATE2 (EIP-1014):
Unknown -> WIP (ethereumjs/ethereumjs-monorepo#329)
SSTORE (EIP-1283):
Unknown -> now merged, ready (ethereumjs/ethereumjs-monorepo#367)
Difficulty Bomb (EIP-1234):
Unknown -> WIP (ethereumjs/ethereumjs-block#54)

@cburgdorf
Copy link

@Souptacular trinity just landed support for EIP-1283 ethereum/py-evm#1410
Only thing left for us is to ensure we run all state tests for constantinople (which should land within the next days)

@dwightguth
Copy link

KEVM now supports constantinople: runtimeverification/evm-semantics#267

We will continue to test with more up-to-date versions of the test suite up until launch.

@ehildenb
Copy link

ehildenb commented Nov 1, 2018

@Souptacular can you add KEVM to the client matrix in the first comment?

@dwightguth I think the first 4 columns we are a "Yes" on, but the last column we are an N/A on because we don't do any fork-choice/block-validation, only execution.

@shemnon
Copy link
Contributor

shemnon commented Nov 1, 2018

Pantheon's github repo is now open and can be linked: https://github.com/PegaSysEng/pantheon

@InoMurko
Copy link

InoMurko commented Nov 4, 2018

Since joined forces have been announced to work on Mana, exthereum should be removed.

@holgerd77
Copy link

EthereumJS: CREATE2 (EIP-1014), Difficulty bomb (EIP-1234): WIP -> Complete

@holgerd77
Copy link

Associated PRs:
CREATE2: ethereumjs/ethereumjs-monorepo#329
Difficulty bomb: ethereumjs/ethereumjs-block#54

@5chdn
Copy link
Contributor

5chdn commented Nov 15, 2018

Might make sense to put this in the wiki, so everyone can edit it. Maybe directly here in the repository? Need a hand @lrettig @Souptacular ?

@holgerd77
Copy link

@5chdn This is the main working sheet for @winsvega to organize test creation, I think the wiki here wouldn't be the right place for this, let's please just stick to linking this as originally suggested.

@5chdn
Copy link
Contributor

5chdn commented Nov 15, 2018

Yeah, I'm just talking about "extending the head" post, it would be easier to have the ability to just edit a wiki somewhere instead of waiting for one person to do it. I'm not talking about adding the content of the links to the wiki.

@lrettig
Copy link
Contributor

lrettig commented Nov 18, 2018

I migrated the progress tracker to a wiki page at https://github.com/ethereum/pm/wiki/Constantinople-Progress-Tracker but it looks like it may still not have global edit access. @Souptacular will have to fix that.

@Souptacular
Copy link
Contributor Author

@lrettig I set up the proper permissions now.

@5chdn
Copy link
Contributor

5chdn commented Nov 20, 2018

Amazing. Updated!

@holgerd77
Copy link

Our EthereumJS VM release v2.5.0 with full Constantinople support (and other goodies like consensus conformity and a revamped state manager) is finally out.

@sea51930
Copy link

sea51930 commented Dec 3, 2018

#63

@5chdn
Copy link
Contributor

5chdn commented Dec 9, 2018

Moving the meta-EIP 1013 to final ethereum/EIPs#1642

I think this tracker can be closed now.

@lrettig
Copy link
Contributor

lrettig commented Dec 12, 2018

Closing

@lrettig lrettig closed this as completed Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests