Enable all Constantinople hard fork changes in constantinople_test.json #9505

sorpaas · 2018-09-10T06:30:57Z

Edit: Hi Redditors! I think what you're looking for is this: #8427

cheme

Is it possible to rename from "Byzatium (test)" to "Constantinople (test)". I know it is technically useless, but it can be confusing. Also I think "blockReward" should be 0x1BC16D674EC80000 (2million).

cheme

LGTM.

cheme

I missed something, I think eip210 (superseded by 1218 which is not making it to constantinople) should not be active.

sorpaas · 2018-09-10T13:35:32Z

Yeah right. Sorry!

5chdn · 2018-09-10T20:41:01Z

ethcore/res/ethereum/constantinople_test.json

 				"homesteadTransition": "0x0",
 				"eip100bTransition": "0x0",
 				"difficultyBombDelays": {
-					"0": 3000000
+					"0": 8000000


Why 8_000_000? What about

"difficultyBombDelays": { "0": 3000000 "5": 2000000 }

to match eip 649, 1234?

I think those json test are used in a all or nothing basis (eg from ethereum test), so putting the sum of eip 649 and 1234 together at 0 makes sense (on two line it would be better but I think json dont allow to identical keys). I got a doubt 649 was a 3 million delay and 1234 another additional 5 million ?

fine by me. 649 is 3 million, 1234 is 2 million. sum is 5 million.

My mistake, when reading 1234, " 5 million blocks later than previously specified with the Homestead fork" gave me the wrong impression of additional 5M but it would have been only true if refering to byzantium fork.
So yes we need to use 5M instead of 8M for this line.

5chdn · 2018-09-10T22:35:44Z

tests::evm::test_blockhash_eip210_int

fails

cheme · 2018-09-11T14:01:44Z

The failing test is an eip210 test which was using the old version of constantinople test. It is a bit outdated (the contract will probably be the one of eip1218 and for next hardfork), I think we should disable the test but keep the code in case eip1218 happens (good starting point).

sorpaas · 2018-09-11T15:51:34Z

@cheme We still have eip210 config flag though. They're not yet deprecated. Before we remove it, how about let's just continue to use this json file to test out test_blockhash_eip210_int? I think creating a new test config just for eip210 might be a little bit overkill.

cheme · 2018-09-11T15:55:54Z

I feel the same way (a new json is a bit overkill), but the constantinople_test.json is going to be used by 'ethereum/tests' json rpc tests. So we may need a eip210_test.json file, or simply disable the test.

Edit: but I can create it in the PR where those tests will be added.

sorpaas · 2018-09-11T16:16:40Z

Added eip210_test.json!

tolgatrz · 2018-09-11T22:09:07Z

what date will it take place?

…on (#9505) * Enable all Constantinople hard fork changes in constantinople_test.json * Address grumbles * Remove EIP-210 activation * 8m -> 5m * Temporarily add back eip210 transition so we can get test passed * Add eip210_test and remove eip210 transition from const_test

* parity-version: mark 2.1.0 track beta * ci: update branch version references * docker: release master to latest * Fix checkpointing when creating contract failed (#9514) * ci: fix json docs generation (#9515) * fix typo in version string (#9516) * Update patricia trie to 0.2.2 crates. Default dependencies on minor version only. * Putting back ethereum tests to the right commit * Enable all Constantinople hard fork changes in constantinople_test.json (#9505) * Enable all Constantinople hard fork changes in constantinople_test.json * Address grumbles * Remove EIP-210 activation * 8m -> 5m * Temporarily add back eip210 transition so we can get test passed * Add eip210_test and remove eip210 transition from const_test * In create memory calculation is the same for create2 because the additional parameter was popped before. (#9522) * deps: bump fs-swap and kvdb-rocksdb * Multithreaded snapshot creation (#9239) * Add Progress to Snapshot Secondary chunks creation * Use half of CPUs to multithread snapshot creation * Use env var to define number of threads * info to debug logs * Add Snapshot threads as CLI option * Randomize chunks per thread * Remove randomness, add debugging * Add warning * Add tracing * Use parity-common fix seek branch * Fix log * Fix tests * Fix tests * PR Grumbles * PR Grumble II * Update Cargo.lock * PR Grumbles * Default snapshot threads to half number of CPUs * Fix default snapshot threads // min 1 * correct before_script for nightly build versions (#9543) - fix gitlab array of strings syntax error - get proper commit id - avoid colon in stings * Remove initial token for WS. (#9545) * version: mark release critical * ci: fix rpc docs generation 2 (#9550) * Improve P2P discovery (#9526) * Add `target` to Rust traces * network-devp2p: Don't remove discovery peer in main sync * network-p2p: Refresh discovery more often * Update Peer discovery protocol * Run discovery more often when not enough nodes connected * Start the first discovery early * Update fast discovery rate * Fix tests * Fix `ping` tests * Fixing remote Node address ; adding PingPong round * Fix tests: update new +1 PingPong round * Increase slow Discovery rate Check in flight FindNode before pings * Add `deprecated` to deprecated_echo_hash * Refactor `discovery_round` branching * net_version caches network_id to avoid redundant aquire of sync read lock (#9544) * net_version caches network_id to avoid redundant aquire of sync read lock, #8746 * use lower_hex display formatting for net_peerCount rpc method * Increase Gas-floor-target and Gas Cap (#9564) + Gas-floor-target increased to 8M by default + Gas-cap increased to 10M by default * Revert to old parity-tokio-ipc. * Downgrade named pipes.

…on (#9505) * Enable all Constantinople hard fork changes in constantinople_test.json * Address grumbles * Remove EIP-210 activation * 8m -> 5m * Temporarily add back eip210 transition so we can get test passed * Add eip210_test and remove eip210 transition from const_test

* ethash: implement EIP-1234 (#9187) * Implement EIP-1052 (EXTCODEHASH) and fix several issues in state account cache (#9234) * Implement EIP-1052 and fix several issues related to account cache * Fix jsontests * Merge two matches together * Avoid making unnecessary Arc<Vec> * Address grumbles * Comply EIP-86 with the new definition (#9140) * Comply EIP-86 with the new CREATE2 opcode * Fix rpc compile * Fix interpreter CREATE/CREATE2 stack pop difference * Add unreachable! to fix compile * Fix instruction_info * Fix gas check due to new stack item * Add new tests in executive * Fix have_create2 comment * Remove all unused references of eip86_transition and block_number * Implement KIP4: create2 for wasm (#9277) * Basic implementation for kip4 * Add KIP-4 config flags * typo: docs fix * Fix args offset * Add tests for create2 * tests: evm * Update wasm-tests and fix all gas costs * Update wasm-tests * Update wasm-tests and fix gas costs * `gasleft` extern implemented for WASM runtime (kip-6) (#9357) * Wasm gasleft extern added * wasm_gasleft_activation_transition -> kip4_transition * use kip-6 switch * gasleft_panic -> gasleft_fail rename * call_msg_gasleft test added and gas_left agustments because this openethereum/wasm-tests#52 * change .. to _ * fix comment for the have_gasleft param * update tests (openethereum/wasm-tests@0edbf86) * Add EIP-1014 transition config flag (#9268) * Add EIP-1014 transition config flag * Remove EIP-86 configs * Change CREATE2 opcode index to 0xf5 * Move salt to the last item in the stack * Change sendersaltandaddress scheme to comply with current EIP-1014 * Fix json configs * Fix create2 test * Fix deprecated comments * EIP 1283: Net gas metering for SSTORE without dirty maps (#9319) * Implement last_checkpoint_storage_at * Add reverted_storage_at for externalities * sstore_clears_count -> sstore_clears_refund * Implement eip1283 for evm * Add eip1283Transition params * evm: fix tests * jsontests: fix test * Return checkpoint index when creating * Comply with spec Version II * Fix docs * Fix jsontests feature compile * Address grumbles * Fix no-checkpoint-entry case * Remove unnecessary expect * Add test for State::checkpoint_storage_at * Add executive level test for eip1283 * Hard-code transaction_checkpoint_index to 0 * Fix jsontests * Add tests for checkpoint discard/revert * Require checkpoint to be empty for kill_account and commit * Get code coverage * Use saturating_add/saturating_sub * Fix issues in insert_cache * Clear the state again * Fix original_storage_at * Early return for empty RLP trie storage * Update comments * Fix borrow_mut issue * Simplify checkpoint_storage_at if branches * Better commenting for gas handling code * Address naming grumbles * More tests * Fix an issue in overwrite_with * Add another test * Fix comment * Remove unnecessary bracket * Move orig to inner if * Remove test coverage for this PR * Add tests for executive original value * Add warn! for an unreachable cause * Update state tests execution model (#9440) * Update & fix JSON state tests. * Update tests to be able to run ethtest at 021fe3d410773024cd5f0387e62db6e6ec800f32. - Touch user in state - Adjust transaction tests to new json format * Switch to same commit for submodule ethereum/test as geth (next includes constantinople changes). Added test `json_tests::trie::generic::TrieTests_trieanyorder` and a few difficulty tests. * Remove trietestnextprev as it would require to parse differently and implement it. * Support new (shitty) format of transaction tests. * Ignore junk in ethereum/tests repo. * Ignore incorrect test. * Update to a later commit * Move block number to a constant. * Fix ZK2 test - touched account should also be cleared. * Fix conflict resolution * Fix checkpointing when creating contract failed (#9514) * In create memory calculation is the same for create2 because the additional parameter was popped before. (#9522) * Enable all Constantinople hard fork changes in constantinople_test.json (#9505) * Enable all Constantinople hard fork changes in constantinople_test.json * Address grumbles * Remove EIP-210 activation * 8m -> 5m * Temporarily add back eip210 transition so we can get test passed * Add eip210_test and remove eip210 transition from const_test * Add constantinople conf to EvmTestClient. (#9570) * Add constantinople conf to EvmTestClient. * Skip some test to update submodule etheureum/tests submodule to latest. * Put skipping 'under issue' test behind a feature. * Change blockReward for const-test to pass ethereum/tests * Update tests to new constantinple definition (change of reward at block 5). Switch 'reference' to string, that way we can include issues from others repo (more flexible)Update tests to new constantinple definition (change of reward at block 5). Switch 'reference' to string, that way we can include issues from others repo (more flexible). * Fix modexp and bn128_mul gas prices in chain config * Changes `run_test_path` method to append its directory results (without that it stop testing at the first file failure). Add some missing tests. Add skip for those (block create2 is one hundred percent false but on hive we can see that geth and aleth got similar issue for this item). * retab current.json * Update reference to parity issue for failing tests. * Hardfork the testnets (#9562) * ethcore: propose hardfork block number 4230000 for ropsten * ethcore: propose hardfork block number 9000000 for kovan * ethcore: enable kip-4 and kip-6 on kovan * etcore: bump kovan hardfork to block 9.2M * ethcore: fix ropsten constantinople block number to 4.2M * ethcore: disable difficulty_test_ropsten until ethereum/tests are updated upstream * Don't hash the init_code of CREATE. (#9688) * Implement CREATE2 gas changes and fix some potential overflowing (#9694) * Implement CREATE2 gas changes and fix some potential overflowing * Ignore create2 state tests * Split CREATE and CREATE2 in gasometer * Generalize rounding (x + 31) / 32 to to_word_size * ethcore: delay ropsten hardfork (#9704) * Add hardcoded headers (#9730) * add foundation hardcoded header #6486017 * add ropsten hardcoded headers #4202497 * add kovan hardcoded headers #9023489 * gitlab ci: releasable_branches: change variables condition to schedule (#9729) * HF in POA Core (2018-10-22) (#9724) poanetwork/poa-chain-spec#87

Enable all Constantinople hard fork changes in constantinople_test.json

32ab7d7

sorpaas added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M2-config 📂 Chain specifications and node configurations. labels Sep 10, 2018

sorpaas added this to the 2.1 milestone Sep 10, 2018

cheme reviewed Sep 10, 2018

View reviewed changes

Address grumbles

522c9b9

cheme approved these changes Sep 10, 2018

View reviewed changes

cheme reviewed Sep 10, 2018

View reviewed changes

Remove EIP-210 activation

c47df60

5chdn approved these changes Sep 10, 2018

View reviewed changes

5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 10, 2018

5chdn mentioned this pull request Sep 10, 2018

Constantinople Progress Tracker ethereum/pm#53

Closed

5chdn added the B0-patchthis 🕷 label Sep 11, 2018

5chdn modified the milestones: 2.1, 2.2 Sep 11, 2018

5chdn mentioned this pull request Sep 11, 2018

Backports for 2.1.0 beta #9518

Merged

21 tasks

cheme mentioned this pull request Sep 11, 2018

Fix a panic on create2 new opcode #9522

Merged

sorpaas added 2 commits September 11, 2018 23:54

8m -> 5m

ad7aa97

Temporarily add back eip210 transition so we can get test passed

6216700

Add eip210_test and remove eip210 transition from const_test

5f0c7c3

sorpaas merged commit 530aac0 into master Sep 11, 2018

sorpaas deleted the sp-reward-grumble branch September 11, 2018 18:17

andresilva mentioned this pull request Oct 9, 2018

[stable] Backport constantinople changes #9723

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable all Constantinople hard fork changes in constantinople_test.json #9505

Enable all Constantinople hard fork changes in constantinople_test.json #9505

sorpaas commented Sep 10, 2018 •

edited

Loading

cheme left a comment

cheme left a comment

cheme left a comment

sorpaas commented Sep 10, 2018

5chdn Sep 10, 2018

cheme Sep 10, 2018

5chdn Sep 10, 2018

cheme Sep 11, 2018

5chdn commented Sep 10, 2018

cheme commented Sep 11, 2018

sorpaas commented Sep 11, 2018

cheme commented Sep 11, 2018 •

edited

Loading

sorpaas commented Sep 11, 2018

tolgatrz commented Sep 11, 2018

Enable all Constantinople hard fork changes in constantinople_test.json #9505

Enable all Constantinople hard fork changes in constantinople_test.json #9505

Conversation

sorpaas commented Sep 10, 2018 • edited Loading

cheme left a comment

Choose a reason for hiding this comment

cheme left a comment

Choose a reason for hiding this comment

cheme left a comment

Choose a reason for hiding this comment

sorpaas commented Sep 10, 2018

5chdn Sep 10, 2018

Choose a reason for hiding this comment

cheme Sep 10, 2018

Choose a reason for hiding this comment

5chdn Sep 10, 2018

Choose a reason for hiding this comment

cheme Sep 11, 2018

Choose a reason for hiding this comment

5chdn commented Sep 10, 2018

cheme commented Sep 11, 2018

sorpaas commented Sep 11, 2018

cheme commented Sep 11, 2018 • edited Loading

sorpaas commented Sep 11, 2018

tolgatrz commented Sep 11, 2018

sorpaas commented Sep 10, 2018 •

edited

Loading

cheme commented Sep 11, 2018 •

edited

Loading