Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum Core Devs Meeting Constantinople Session 2 Agenda #61

Closed
Souptacular opened this issue Oct 16, 2018 · 15 comments
Closed

Ethereum Core Devs Meeting Constantinople Session 2 Agenda #61

Souptacular opened this issue Oct 16, 2018 · 15 comments

Comments

@Souptacular
Copy link
Contributor

Souptacular commented Oct 16, 2018

Ethereum Core Devs Meeting Constantinople Session 2 Agenda

Meeting Date/Time: Friday 19 October 2018 at 14:00 UTC

Meeting Duration 1 hour

YouTube Live Stream Link

Constantinople Progress

Agenda

  1. Ropsten issues.
  2. When fork?
@5chdn
Copy link
Contributor

5chdn commented Oct 17, 2018

Maybe a good idea to collect all the issues here, so everyone is on the same page and we can focus on resolving problems rather than talking about what happened on the call:

Meta issues

  • recently added hashpower caused reduced blocktimes and caused this hardfork to happen much earlier than expected on a Saturday which is by all means the worst time for a hardfork
  • hardfork happened only 6 days after Geth release and 1 day after Parity Ethereum release, users had not enough time to upgrade
  • not a single miner was mining on the Constantinople chain, it took us two hours to find someone to sync an updated Ropsten node and start mining 4_230_000 while Byzantium chain was happly grinded at ~1 GH/s
  • there is no fork monitor available, only http://ropsten-stats.parity.io which does not reveal details about the different chains

Client issues

Anything else?

Edit: Lane moved this to the forum, makes sense: https://ethereum-magicians.org/t/issues-we-discovered-in-the-ropsten-constantinople-hard-fork/1598

@lows93
Copy link

lows93 commented Oct 17, 2018

will we go back to the future ?

`Meeting Date/Time: Friday 31 August 2018 at 14:00 UTC´

@lrettig
Copy link
Contributor

lrettig commented Oct 17, 2018

Fixed the date

@Souptacular
Copy link
Contributor Author

lol @lrettig we fixed it at literally the exact same minute and GitHub errored out for me.

@lrettig
Copy link
Contributor

lrettig commented Oct 17, 2018

Good to know consensus by GitHub works so well 👍

@lrettig
Copy link
Contributor

lrettig commented Oct 17, 2018

This is my attempt to summarize the things that went wrong - and by extension, things I'd love to discuss on Friday's call. Please make additions/corrections! https://ethereum-magicians.org/t/issues-we-discovered-in-the-ropsten-constantinople-hard-fork/1598.

@5chdn - thanks for getting the list started above. Mine includes most of the ones on your list, with slightly more focus on "process" and less on code. We can try to merge them into a canonical list if you like. I have a slight preference for keeping threaded conversation on the FEM forum and using Github more for high-level process, call scheduling, etc.

@5chdn
Copy link
Contributor

5chdn commented Oct 17, 2018

I approve this thread, Lane, and I appreciate that you collected all these items. There are two differences though:

  1. I tried to order my items in a chronological manner.
  2. I tried to focus on all the things that are immediately important for the call.

But it totally makes sense to also go through the additional questions you raised, but maybe not all in one call 🤣

@AlexeyAkhunov
Copy link
Contributor

I will not be able to join the call. I have read @lrettig thread on Magicians. What is missing there and also here: we need to answer the question: "What is the plan between now and mainnet hard-fork?". Clearly, we are not rolling back Ropsten, and keep testing things there. So I propose regularly spawning (and mining) temporary test nets to test transition to Constantinople with any clients that want to participate. It is important to test both the new code (on Ropsten now), and the tools and processes used for transition (not possible on Ropsten anymore).

@AlexeyAkhunov
Copy link
Contributor

Oh, and also forgot another suggestion - what about bounties for causing consensus issues on Ropsten?

@egalano
Copy link

egalano commented Oct 19, 2018

I'd like to propose bounties for running nodes or mining on Ropsten as well to encourage more community participation. At the very least during the periods leading up to a fork.

@5chdn
Copy link
Contributor

5chdn commented Oct 19, 2018

we need to answer the question: "What is the plan between now and mainnet hard-fork?"

Tests! :)

@eggy-eth
Copy link

eggy-eth commented Oct 19, 2018

How about someone also writes down the main points which are discussed in the call? I would really like to know, for example, what the consensus is on the second point. I know I can also listen to the call again, but this means I have to spend a hour to listening to the video to farm out all the points which have to be raised. I really think it would help more people as well to quickly get a "tldr" of the call.

EDIT: Eggy should read. It's already there, except not this meeting.

@lows93
Copy link

lows93 commented Oct 19, 2018

So tldw;

  • Mainnet Hardfork not before January / End of January
  • time between release Hardfork-Client and the Hardfork itself should be atleast 4 Weeks
  • possible Progw for the upcoming Hardfork
  • for Istanbul and further Hardforks there should be a Testphase on Testnet for min. half a year

@lrettig
Copy link
Contributor

lrettig commented Oct 19, 2018

Notes are up: https://github.com/ethereum/pm/blob/master/All%20Core%20Devs%20Meetings/Constantinople%20Meeting%202.md

@lrettig lrettig closed this as completed Oct 19, 2018
@olalawal
Copy link

olalawal commented Oct 20, 2018

If progpow is a definate go for implementation in the delayed fork.. Me and my conglomerate of freelance miners are happy to set up a pool on Testnet and provide testing. We currently run a BCI progpow pools and Yiimp as well.

our discord:
https://discord.gg/7VRe2aW

If ProgPow is not going to be deployed as part of the implementation we will not be interested in testing .. most of our miners are mining xmr , raven, bci .. asic/fpga proof algos.

xmr just forked a few days ago , and shed around 20 % of fpga hash

lrettig pushed a commit that referenced this issue May 12, 2019
* Meeting 61.md

Transcript meeting #61

* Some minor formatting and tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants