Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Implement net gas metering for SSTORE in LegacyVM #5231

Merged
merged 3 commits into from
Aug 31, 2018
Merged

Implement net gas metering for SSTORE in LegacyVM #5231

merged 3 commits into from
Aug 31, 2018

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Aug 29, 2018

@gumb0 gumb0 added this to the Constantinople milestone Aug 29, 2018
@gumb0
Copy link
Member Author

gumb0 commented Aug 29, 2018

I will better move tabs conversion to separate PR

@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #5231 into master will increase coverage by 0.17%.
The diff coverage is 97.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5231      +/-   ##
==========================================
+ Coverage   60.67%   60.84%   +0.17%     
==========================================
  Files         338      338              
  Lines       27450    27562     +112     
  Branches     3184     3194      +10     
==========================================
+ Hits        16656    16771     +115     
+ Misses       9667     9666       -1     
+ Partials     1127     1125       -2

@gumb0
Copy link
Member Author

gumb0 commented Aug 29, 2018

Code in Account/State still should be improved and better documented, but I'll add some tests first.

@gumb0
Copy link
Member Author

gumb0 commented Aug 30, 2018

I did some refactoring in State/Account making the caches m_storageOverlay and m_storageOriginal be updated only inside Account. This requires OverlayDB* being passed to storage getters, but still it seems simpler this way.

@gumb0 gumb0 removed the in progress label Aug 30, 2018
@gumb0 gumb0 requested a review from chfast August 30, 2018 16:46
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. This is excellent work.

@gumb0 gumb0 merged commit fdbb63a into master Aug 31, 2018
@gumb0 gumb0 deleted the net-sstore branch August 31, 2018 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants