ParallelUnbalancedWork for efficient unbalanced parallel loops #7787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Nethermind/Nethermind.Consensus/Processing/BlockCachePreWarmer.cs
Outdated
Show resolved
Hide resolved
- Introduced the `ParallelUnbalancedWork` class to efficiently execute parallel loops over a range of integers, handling unbalanced workloads. - Added static `For` methods to support parallel execution with and without thread-local data, including initialization and finalization functions. - Utilized thread pooling and a shared counter (`SharedCounter`) to distribute iterations among threads dynamically. - Implemented internal classes (`BaseData`, `Data`, and `InitProcessor<TLocal>`) to manage shared state and thread synchronization. - Aimed to optimize performance in scenarios where the workload per iteration is uneven, ensuring better resource utilization and reduced execution time.
benaadams
force-pushed
the
parallel-unbalanced-work
branch
from
0072faa to
061956a
Compare
|
LukaszRozmej
approved these changes
Dec 2, 2024
| { | ||
| IReadOnlyTxProcessorSource env = _envPool.Get(); | ||
| int i = 0; | ||
| IReadOnlyTxProcessorSource env = state.preWarmer._envPool.Get(); |
There was a problem hiding this comment.
super minor: maybe better to pass the pool directly rather than whole prewarmer as it is not needed?
And maybe build custom struct for it as those are used in 2 places?
Comment on lines
+193
to
+199
| public int ActiveThreads => Volatile.Read(ref _activeThreads); | ||
|
|
||
| /// <summary> | ||
| /// Marks a thread as completed. | ||
| /// </summary> | ||
| /// <returns>The number of remaining active threads.</returns> | ||
| public int MarkThreadCompleted() |
There was a problem hiding this comment.
minor: in theory this could be misused by calling MarkThreadCompleted first, but as this is private class we can ignore it.
I agree this should be in dotnet itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ParallelUnbalancedWorkclass to efficiently execute parallel loops, handling unbalanced workloads.SharedCounterto distribute iterations among threads dynamically..Waiting for background threads to completeParallel.ForTypes of changes
What types of changes does your code introduce?
Testing
Requires testing