Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate validator start up #43

Merged
merged 11 commits into from
Jun 17, 2022
Merged

Automate validator start up #43

merged 11 commits into from
Jun 17, 2022

Conversation

AntiD2ta
Copy link
Member

@AntiD2ta AntiD2ta commented Jun 10, 2022

Closes #41

Changes:

  • Move cobra commands files to new cli package.
  • Integrate Posmoni monitoring tool to track execution and consensus clients sync progress
  • Start validator automatically after execution and consensus nodes are synced

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some
The cli command workflow needs more test cases. Also sanity tests are also required.

@AntiD2ta AntiD2ta added enhancement New feature or request on-premise Changes on on-premise setup main High priority labels Jun 10, 2022
@AntiD2ta AntiD2ta added this to the 0.1 milestone Jun 10, 2022
@AntiD2ta AntiD2ta self-assigned this Jun 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #43 (5f15574) into develop (6791b92) will increase coverage by 2.37%.
The diff coverage is 60.77%.

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    77.86%   80.24%   +2.37%     
===========================================
  Files           25       27       +2     
  Lines         1274     1311      +37     
===========================================
+ Hits           992     1052      +60     
+ Misses         245      218      -27     
- Partials        37       41       +4     
Flag Coverage Δ
unittests 80.24% <60.77%> (+2.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/down.go 55.00% <ø> (ø)
cli/keys.go 51.16% <ø> (ø)
cli/listClients.go 88.23% <ø> (ø)
cli/logs.go 74.28% <ø> (ø)
cli/root.go 81.42% <ø> (ø)
cli/cli.go 49.64% <49.64%> (ø)
cli/cli_utils.go 66.66% <100.00%> (ø)
cli/version.go 100.00% <100.00%> (ø)
internal/utils/testing.go 100.00% <100.00%> (ø)
internal/utils/utils.go 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6791b92...5f15574. Read the comment docs.

@AntiD2ta AntiD2ta linked an issue Jun 10, 2022 that may be closed by this pull request
Makefile Show resolved Hide resolved
@AntiD2ta AntiD2ta merged commit 1a4c09c into develop Jun 17, 2022
@AntiD2ta AntiD2ta deleted the feature/41-full-1click branch June 17, 2022 05:20
D-DePablos pushed a commit to D-DePablos/sedge that referenced this pull request Aug 12, 2022
* fix: Skip tests that only work on linux envs

* feat: Add CheckErr utility function for tests

* chore(gitignore): Ignore .vscode folder

* doc(makefile): Comment codecov-test rule

* feat(cli): Integrate posmoni monitoring tool to track sync progress of nodes

Also start validator service after execution and consensus clients are sync

* fix(cli): Incomplete validation check for --run-clients flag

Added ContainsOnly utility function for string slices

* refac: Move cobra commands files to new cli package

Leave main.go in cmd/

* feat(cli): Make 1click completely 1click

Run validator node after execution and consensus client are synced

* feat(makefile): Add compile-linux rule for linux build

* ci: Update binary

* chore: Update go.mod and go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main High priority on-premise Changes on on-premise setup
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Track sync status of nodes to automate validator start up
3 participants