-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate validator start up #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f nodes Also start validator service after execution and consensus clients are sync
Added ContainsOnly utility function for string slices
Leave main.go in cmd/
Run validator node after execution and consensus client are synced
AntiD2ta
added
enhancement
New feature or request
on-premise
Changes on on-premise setup
main
High priority
labels
Jun 10, 2022
Codecov Report
@@ Coverage Diff @@
## develop #43 +/- ##
===========================================
+ Coverage 77.86% 80.24% +2.37%
===========================================
Files 25 27 +2
Lines 1274 1311 +37
===========================================
+ Hits 992 1052 +60
+ Misses 245 218 -27
- Partials 37 41 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cbermudez97
reviewed
Jun 12, 2022
cbermudez97
reviewed
Jun 12, 2022
cbermudez97
approved these changes
Jun 12, 2022
D-DePablos
pushed a commit
to D-DePablos/sedge
that referenced
this pull request
Aug 12, 2022
* fix: Skip tests that only work on linux envs * feat: Add CheckErr utility function for tests * chore(gitignore): Ignore .vscode folder * doc(makefile): Comment codecov-test rule * feat(cli): Integrate posmoni monitoring tool to track sync progress of nodes Also start validator service after execution and consensus clients are sync * fix(cli): Incomplete validation check for --run-clients flag Added ContainsOnly utility function for string slices * refac: Move cobra commands files to new cli package Leave main.go in cmd/ * feat(cli): Make 1click completely 1click Run validator node after execution and consensus client are synced * feat(makefile): Add compile-linux rule for linux build * ci: Update binary * chore: Update go.mod and go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
Changes:
cli
package.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Comments about testing , should you have some
The
cli
command workflow needs more test cases. Also sanity tests are also required.