-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul IndexSeries and add "order_of_images" to Images #459
Conversation
Maybe add |
I added an |
TODO: Allow |
TODO: consider how images are referenced in a table of image presentations (on time, off time, other metadata). Is it possible to reference an Image from a column in a TimeIntervals or other DynamicTable? |
After discussing this issue with @oruebel, we decided to postpone resolving this until NWB 2.5.0 while we consider the different options and talk with relevant parties. Another idea is to create an |
@bendichter lets revisit this PR during our next sync |
Upon discussion with @oruebel and @bendichter, we decided to implement:
We decided not to implement the We could also revamp i.e. neurodata_type_def: ImageReferenceSeries
neurodata_type_inc: NWBContainer
# NOTE this is not a TimeSeries because the dtype of data is not numeric and does not have attributes conversion, resolution, offset, unit
doc: A TimeSeries-like container that represents the times at which different images were displayed or acquired.
datasets:
- name: data
dtype:
target_type: Image
reftype: object
dims:
- num_times
shape:
- null
doc: References to images stored in this object.
- neurodata_type_inc: Image
doc: Images stored in this collection.
quantity: '+'
- ... # description, timestamps, etc. As designed in this PR, the API or user must do the following to get the images used in the images_container = nwbfile.stimulus_templates.get("Images")
images = [images_container.ordered_images[x] for x in index_series.data[:]] Whereas with the images = image_reference_series.data[:] @oruebel and @bendichter, what do you think? I am happy to go either way on new |
looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fix #458