Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 2.5.0 release #511

Merged
merged 8 commits into from
Jun 14, 2022
Merged

Prepare 2.5.0 release #511

merged 8 commits into from
Jun 14, 2022

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 20, 2022 •
edited
Loading

@rly rly mentioned this pull request Apr 20, 2022
Merged
6 tasks
@bendichter
Copy link
Contributor

@oruebel and I would like to add #512

@rly rly marked this pull request as ready for review May 3, 2022 15:22
@rly
Copy link
Contributor Author

rly commented Jun 7, 2022 •
edited
Loading

@lawrence-mbf NWB schema 2.5.0 is ready for release. Do you foresee any issues with adding support for these changes in MatNWB?

lawrence-mbf
lawrence-mbf previously approved these changes Jun 7, 2022
View reviewed changes
Copy link

@lawrence-mbf lawrence-mbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bendichter
bendichter approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rly rly merged commit 761a0d7 into dev Jun 14, 2022
@rly rly deleted the prepare_2.5.0 branch June 14, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter approved these changes

@lawrence-mbf lawrence-mbf lawrence-mbf left review comments

@oruebel oruebel Awaiting requested review from oruebel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rly @bendichter @lawrence-mbf