-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for some electrodes table columns #498
Conversation
This change does not match with my understanding of this field. rel_x, y, and z and position on the probe. This should remain the same even if the probe is rotated in the brain, so it doesn't make sense to put this in terms of the anatomical coordinates of the brain. |
@bendichter That makes sense. I will update the PR. Would it be useful to allow the user to specify an origin point / the reference frame for the rel_x, rel_y, and rel_z positions? I know for kilosort, the |
@rly I think it would be good for us to try to converge with ProbeInterface on these types of questions. |
Summary of changes
The
rel_x
,rel_y
,rel_z
, andreference
columns of the electrodes table are confusing users.This PR clarifies the documentation string.
PR checklist for schema changes
docs/format/source/format_release_notes.rst