Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the app's window is associated with its Desktop Entry #2386

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

MattSturgeon
Copy link
Contributor

@MattSturgeon MattSturgeon commented Dec 15, 2024

This is used to associate the Desktop Entry with the running application, e.g. in taskbars, panels, and docks.Set StartupWMClass so that the Desktop Entry gets properly associated with the running app window.

image

When the app is associated with its Desktop Entry, the DE knows which icon to use for the app's window.

With this PR, the window name and icon show correctly in the dock as:
image


Inspecting with GNOME's Looking Glass (Alt+F2, lg), shows the WM Class for the app's window is unsurprisingly NexusMods.App.
Screenshot From 2024-12-15 20-42-20

After this PR, it shows association with the Desktop Entry:
image


EDIT: moved the single window stuff to #2387

This is used to associate the Desktop Entry with the running
application, e.g. in taskbars, panels, and docks.
@MattSturgeon MattSturgeon changed the title Set StartupWMClass in freedesktop Desktop Entry Ensure the app's window is associated with its Desktop Entry Dec 15, 2024
@MattSturgeon MattSturgeon force-pushed the desktop-entry-wm-class branch from cb7e32b to aa04fd6 Compare December 15, 2024 21:50
Copy link
Member

@erri120 erri120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@erri120 erri120 merged commit 4430631 into Nexus-Mods:main Dec 16, 2024
11 checks passed
@MattSturgeon MattSturgeon deleted the desktop-entry-wm-class branch December 16, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants