Set SingleMainWindow in Desktop Entry
#2387
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erri120
approved these changes
Dec 15, 2024
Sewer56
approved these changes
Dec 16, 2024
|
This PR conflicts with |
This indicates to the DE that the app usually runs with a single "main" window, and doesn't support opening additional instances. This can be used by desktops to disable "New Window" actions in the right-click menu.
MattSturgeon
force-pushed
the
desktop-entry-single-window
branch
from
7e3224e to
99f2a19
Compare
|
This PR doesn't conflict with |
|
@Sewer56 https://github.com/Sewer56/PupNet-Deploy/tree/main/PupNet/Assets it looks like we have appimagetool builds in the deploy project that are outdated. I think we can just upgrade that. |
|
@erri120 Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2386, this tells the DE that we don't need a "New Window" button because we typically only have one single "main" window.
SingleMainWindowis a hint to DEs for whether to offer a "New Window" button.This makes sense for NexusMods.App, because it only supports having one "main" window open.
The CI is unhappy about
SingleMainWindow:https://github.com/Nexus-Mods/NexusMods.App/actions/runs/12342433935/job/34442250123?pr=2386#step:8:1375
The CI is validating against Desktop Entry Spec v1.0, however
SingleMainWindowwas added in v1.5.I'm not sure if we can have this as an
X-prefixed option and it still work, need to test that out. Otherwise, is it possible for the linter to support a newer Desktop Entry Spec version?