Skip to content

Conversation

@MarceloLagos
Copy link
Contributor

Performing a check on the uploaded key looking for -----BEGIN RSA (should it be less specific like just BEGIN RSA?).
Then modify the openssl command to:

  1. Use either rsa or ec to validate the key.
  2. Sending standard error to standard output to catch all output (ec validation seems to send it to output error even when successful)

Finally modify the result verification by adding the string to be found on EC key validation (key valid) which is different than the one in RSA validation (key ok).

@jc21
Copy link
Member

jc21 commented Oct 18, 2020

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-666

@jc21 jc21 changed the base branch from master to develop October 18, 2020 07:51
@jc21
Copy link
Member

jc21 commented Oct 18, 2020

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-666

@jc21 jc21 merged commit ffd2430 into NginxProxyManager:develop Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants