Skip to content

Check key for RSA header otherwise use EC, and output fix. #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2020
Merged

Check key for RSA header otherwise use EC, and output fix. #666

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
301499d
Merge pull request #659 from jc21/develop
jc21 Oct 16, 2020
7ba58bd
Update certificate.js
MarceloLagos Oct 18, 2020
190cd2d
Update certificate.js
MarceloLagos Oct 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions backend/internal/certificate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,12 +608,12 @@ const internalCertificate = {
checkPrivateKey: (private_key) => {
return tempWrite(private_key, '/tmp')
.then((filepath) => {
return utils.exec('openssl rsa -in ' + filepath + ' -check -noout')
let key_type = private_key.includes('-----BEGIN RSA') ? 'rsa' : 'ec';
return utils.exec('openssl ' + key_type + ' -in ' + filepath + ' -check -noout 2>&1 ')
.then((result) => {
if (!result.toLowerCase().includes('key ok')) {
throw new error.ValidationError(result);
if (!result.toLowerCase().includes('key ok') && !result.toLowerCase().includes('key valid') ) {
throw new error.ValidationError('Result Validation Error: ' + result);
}

fs.unlinkSync(filepath);
return true;
}).catch((err) => {
Expand Down