Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project jobset: update search #1112

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 14, 2022

Extracted from #1093.

My methodology here is to:

  1. Pick a commit from Builds: drop the jobset and project columns #1093
  2. Check out the parent commit
  3. Run the test suite and identify failing tests
  4. Check out the picked commit and run those failing tests
  5. Verify the picked commit fixed at least one test.

If it didn't, write a test and verify it is broken before / fixed after the picked commit.

The picked commit in this case was search: fix references to jobset / project info.

@grahamc grahamc force-pushed the project-jobset/search branch from c1c38bc to c7c4759 Compare January 14, 2022 21:38
@grahamc grahamc merged commit 3a03784 into NixOS:master Jan 14, 2022
@grahamc grahamc deleted the project-jobset/search branch January 14, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant