-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds: drop the jobset and project columns #1093
Merged
grahamc
merged 5 commits into
NixOS:master
from
DeterminateSystems:builds-jobset-project
Jan 17, 2022
Merged
Builds: drop the jobset and project columns #1093
grahamc
merged 5 commits into
NixOS:master
from
DeterminateSystems:builds-jobset-project
Jan 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ad13b8
to
7d5be1b
Compare
This was referenced Jan 11, 2022
0e160cb
to
989e5e0
Compare
e80e789
to
ebed42f
Compare
ebed42f
to
7521791
Compare
This was referenced Jan 14, 2022
70dcf9b
to
c1e08e2
Compare
c1e08e2
to
1e1cafb
Compare
04d54e4
to
1d5e971
Compare
1d5e971
to
ff8089d
Compare
This was referenced Jan 15, 2022
ff8089d
to
8bbd17d
Compare
8bbd17d
to
79fcf93
Compare
79fcf93
to
1e448a5
Compare
Indexes were haphazardly dropped.
1e448a5
to
c8dc6a9
Compare
welp, here goes |
Timestamps of the deploy:
|
Dropping these 2 columns and 5 indexes cut h.n.o's on-disk database size by 187G (uncompressed) / 51G (compressed):
|
Getting logs from postgres starting with the migration:
useful for: https://github.com/NixOS/nixos-org-configurations/wiki/pgbadger re:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR which is not carefully validated. The tests do pass which is nice to see. However, I've barely even started the webserver or clicked around.
The project and jobset columns were the only foreign key to a jobset and project. #969 added a jobset_id as a replacement, but didn't go all the way to dropping the now duplicate columns. This PR finishes that.
I think a good way to apply this PR is to pull out individual commits, updating individual systems and merging / deploying them one at a time, validating in production that the change didn't break anything. This way, we can easily revert changes if it is the easiest solution.
Several commits in this PR implemented the easiest possible solution to make a test pass. Those patches should be undone, and reimplemented. One good example of this is the json_hints change which critically breaks the API. Another example is the dropping of several indexes without consideration for how it impacts the performance properties of Hydra.
--
before this PR:
after this PR followed by a
vacuum full builds
(which took 3734085.204 ms):a reduction of 14GB.