Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project jobset: Update DeclarativeJobsets to not use the project or jobsets columns on Bulids #1118

Merged

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 15, 2022

Extracted from #1093.

My methodology here is to:

  1. Pick a commit from Builds: drop the jobset and project columns #1093
  2. Check out the parent commit
  3. Run the test suite and identify failing tests
  4. Check out the picked commit and run those failing tests
  5. Verify the picked commit fixed at least one test.

If it didn't, write a test and verify it is broken before / fixed after the picked commit.

In this case there was no failing test so I wrote one, and extracted the "get the jobset name from the jobset table" commit.

@grahamc grahamc merged commit f1a608a into NixOS:master Jan 15, 2022
@grahamc grahamc deleted the project-jobset/declarativejobsets branch January 15, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant